Skip to content

Conversation

@MrBartWolf
Copy link
Contributor

This is the null pull request for options. It should be clean from the current master, without the ui stuff.

@MrBartWolf
Copy link
Contributor Author

I'm not sure why the testing check is not being performed. @Zamua @lam2mo

@lam2mo
Copy link
Member

lam2mo commented Apr 7, 2020

Hmmm. It seems it has failed: https://travis-ci.org/github/JMU-CS/less-java/builds/671871294

I'm not sure why it's not displaying that result here. Seems like it might be a file permissions problem again with lj not being executable.

@lam2mo
Copy link
Member

lam2mo commented Apr 7, 2020

Now it seems there's an output ordering issue: https://travis-ci.org/github/JMU-CS/less-java/builds/672301808

Did you inadvertently change the ordering of the testing vs. running output?

@MrBartWolf
Copy link
Contributor Author

It wasn't inadvertent, you asked me to so that testing would come before running. I just forgot to change the order of the expected outputs of the tests. My bad.

@lam2mo
Copy link
Member

lam2mo commented Apr 8, 2020

Ah, gotcha. Seems there's still at least one that's in the wrong order: https://travis-ci.org/github/JMU-CS/less-java/builds/672306758

@MrBartWolf
Copy link
Contributor Author

The branch was out of date. I'm still not sure why it isn't displaying but it passes travis now.

@lam2mo
Copy link
Member

lam2mo commented Apr 8, 2020

@Zamua
Copy link
Contributor

Zamua commented Apr 8, 2020

Looks fine to me. @lam2mo feel free to merge

@Zamua
Copy link
Contributor

Zamua commented Apr 8, 2020

And could we link the issue that this is resolving?

@lam2mo
Copy link
Member

lam2mo commented Apr 8, 2020

Closes #92. Thanks @MrBartWolf!

@lam2mo lam2mo closed this Apr 8, 2020
@lam2mo lam2mo reopened this Apr 8, 2020
@lam2mo lam2mo merged commit 462beed into JMU-CS:master Apr 8, 2020
@lam2mo
Copy link
Member

lam2mo commented Apr 8, 2020

Sorry, I thought that the "closes" message would clean it up. Clearly not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants