Support for get and a few other things #1

Merged
merged 8 commits into from Jan 30, 2013

2 participants

@jongilbraith

I've added the ability to specify the http method in ttt_call() and in redirect and gather scopes.

Important note: one of my changes is to modify the argument signature for ttt_call() to use an options hash. Thought it would be tidier given the method would take the number of optional arguments to three.

Also did a few other minor little bits and bobs (tidying, etc).

Jon Gilbraith added some commits Jan 25, 2013
Jon Gilbraith Add info about running tests to the README. 14dfd9a
Jon Gilbraith Rename dummy app views to use underscore naming convention. 2f97677
Jon Gilbraith Add .gitkeep to spec/dummy/db.
Absence causes errors first time you create your db.
5b00760
Jon Gilbraith Modify argument signature of CallInProgress#initialize, and so ttt_ca…
…ll().

An options hash instead of multiple "could be nil" args is neater and will better support addition of more options.
0d4ee83
Jon Gilbraith Modify argument signature of post_for_twiml!.
For similar reasons to before.
e2d36a6
Jon Gilbraith Bump version. abe7480
Jon Gilbraith Add support for specifying http method rather than defaulting to post.
* ttt_call()
* in Gather scope
* in Redirect scope
c8bfaf0
@JMongol

Should be "raise" not "rasie".

Good spot, will fix.

@JMongol
Owner

Thanks for the work on this! Looks great except for a small typo ("rasie" instead of "raise"). Ping me when you've fixed that and I'll merge, test, and republish the gem.

@jongilbraith

Thanks Jack, commit pushed fixing typo.

Cheers!

Jon

@JMongol JMongol merged commit 4d5d611 into JMongol:master Jan 30, 2013
@JMongol
Owner

New gem is sitting on my computer ready to go, but rubygems.org is down (for push), so it will go up later today.

@jongilbraith

Cheers Jack. Nearly home time here so will check back again in the morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment