Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of two Vector4d #170

Closed
alessandrofelder opened this issue Sep 12, 2018 · 1 comment
Closed

Addition of two Vector4d #170

alessandrofelder opened this issue Sep 12, 2018 · 1 comment
Labels
bug
Milestone
1.9.12 release

Comments

@alessandrofelder
Copy link

I think there are some problems adding Vector4ds
The methods
public Vector4d add(Vector4dc v, Vector4d dest)
public Vector4d add(Vector4fc v, Vector4d dest)
do not use the input parameter v, but add this to itself...
Also:
public Vector4d add(double x, double y, double z, double w, Vector4d dest) subtracts two vectors instead of adding them. Probably the consequence of copy-pasting, the comments of the add method above say "subtract"
@httpdigest httpdigest added the bug label Sep 12, 2018
@httpdigest httpdigest added this to the 1.9.12 release milestone Sep 12, 2018
httpdigest added a commit that referenced this issue Sep 12, 2018
@httpdigest
Fix Vector4d.add() methods (#170)
baed1c5
@httpdigest
Copy link
Member

Indeed. Thanks for reporting it! Fixed with baed1c5
Next 1.9.12-SNAPSHOT is currently being built and uploaded to oss.sonatype.org by https://travis-ci.org/JOML-CI/JOML/jobs/427811334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.9.12 release
Development

No branches or pull requests
2 participants
@httpdigest @alessandrofelder