Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add ctrl+click hyperlinks for Haskell identifiers and URLs in .hs files #123

Merged
merged 4 commits into from Jul 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

letmaik commented Jul 8, 2013

This implements #117, URLs are also working, no matter where they are. There are some edge cases where the behavior is a bit funny, e.g. when you have test = "http://google.com" then the URL detector and the Haskell detector are competing with each other when hovering the URL (the first one wins). This could be fixed by ignoring such things as strings completely, but this must be fixed in the regular "Open Declaration" action, as I make use of that code.

It works quite well, also very fast. I noticed though that sometimes the buildwrapper process isn't long-running (after certain actions, don't know) and then each call to thingatpoint spawns a new process which gets really slow. But this is unrelated to this pull request and should be fixed in general.

@JPMoresmau JPMoresmau added a commit that referenced this pull request Jul 9, 2013

@JPMoresmau JPMoresmau Merge pull request #123 from neothemachine/master
Add ctrl+click hyperlinks for Haskell identifiers and URLs in .hs files
cc83920

@JPMoresmau JPMoresmau merged commit cc83920 into JPMoresmau:master Jul 9, 2013

Owner

JPMoresmau commented Jul 9, 2013

Thanks a million, works a treat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment