Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Rename Open Definition ~> Open Declaration #59

Merged
merged 2 commits into from

2 participants

@Oblosys

This way the default key for Open Declaration for "In Windows" also works for EclipseFP. The problem with the name Open Definition is that sometimes its context 'Haskell Editor Context' disappears, after which you cannot bind it to the same key as Open Declaration without causing clashes.

In some weird way Eclipse manages to cache the old item, even when a fresh workspace is created. I haven't been able to track down when it refreshes that cache, but it does seem to happen eventually.

I've only updated the labels, since updating the code might introduce problems which are very hard to track down due to the caching issue.

@Oblosys

I've also bumped the required buildwrapper version, because otherwise parsing ranges fails.

@JPMoresmau JPMoresmau merged commit 5e9f52a into JPMoresmau:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 30, 2012
  1. @Oblosys
Commits on Aug 1, 2012
  1. @Oblosys
This page is out of date. Refresh to see the latest.
View
9 net.sf.eclipsefp.haskell.ui/plugin.properties
@@ -114,10 +114,11 @@ ctxMenu_refactor_label = Refactor
# [Navigation]
openActionSet_label = Open Actions
openActionSet_description = Action set containing open actions
-openDefinitionAction_label = &Open Definition
-openDefinitionAction_tooltip = Opens an editor on the definition of the selected element
-openDefinitionCommand_name = &Open Definition
-openDefinitionCommand_desc = Opens an editor on the definition of the selected element
+openDefinitionAction_label = &Open Declaration
+openDefinitionAction_tooltip = Opens an editor on the declaration of the selected element
+openDefinitionCommand_name = &Open Declaration
+openDefinitionCommand_desc = Opens an editor on the declaration of the selected element
+# NOTE: open declaration is referred to as open definition in the code
searchHoogleAction_label = Search in &Hoogle
searchHoogleAction_tooltip = Search for the select element in Hoogle
View
2  net.sf.eclipsefp.haskell.ui/src/net/sf/eclipsefp/haskell/ui/internal/scion/ScionManager.java
@@ -80,7 +80,7 @@
/** Haskell console high water mark */
private int hConHighWater;
- private final static String MINIMUM_BUILDWRAPPER="0.6.0";
+ private final static String MINIMUM_BUILDWRAPPER="0.6.1";
private final static String MINIMUM_SCIONBROWSER="0.2.10";
public ScionManager() {
Something went wrong with that request. Please try again.