small fixes relating to alex, happy, and hlint build steps #82

Merged
merged 2 commits into from Jan 9, 2013

Conversation

Projects
None yet
2 participants
@yiding

yiding commented Jan 9, 2013

fix cabal and happy build step error reporting

one small caveat is that if cabal is configured to generate alex and happy parsers, then the errors could be reported twice.

run hlint with working dir set to project root

this lets HLint.hs file for configuring hlint live in the project dir, which I feel is more natural than peppering them in every subdirectory.

yiding added some commits Jan 9, 2013

fix alex and happy's build runner error parser
use stderr if it's not empty, previously it always picked stdout and the
error messages were being ignored. Also rewrote the error parser to
match "file:lineno: msg" and "file:lineno:colno: msg" formats with a
regex. The old could would throw exceptions in certian cases, causing
the error messages to be hidden.
run hlint with working dir set to project dir
This seems to be a more sensible choice than the file's directory and
allows HLint hint files to be specified on the project root.

JPMoresmau added a commit that referenced this pull request Jan 9, 2013

Merge pull request #82 from yiding/master
small fixes relating to alex, happy, and hlint build steps

@JPMoresmau JPMoresmau merged commit 828208d into JPMoresmau:master Jan 9, 2013

@JPMoresmau

This comment has been minimized.

Show comment
Hide comment
@JPMoresmau

JPMoresmau Jan 9, 2013

Owner

Thanks a lot, changes merged!

Owner

JPMoresmau commented Jan 9, 2013

Thanks a lot, changes merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment