Skip to content

small fixes relating to alex, happy, and hlint build steps #82

Merged
merged 2 commits into from Jan 9, 2013

2 participants

@yiding
yiding commented Jan 9, 2013

fix cabal and happy build step error reporting

one small caveat is that if cabal is configured to generate alex and happy parsers, then the errors could be reported twice.

run hlint with working dir set to project root

this lets HLint.hs file for configuring hlint live in the project dir, which I feel is more natural than peppering them in every subdirectory.

yiding added some commits Jan 8, 2013
@yiding yiding fix alex and happy's build runner error parser
use stderr if it's not empty, previously it always picked stdout and the
error messages were being ignored. Also rewrote the error parser to
match "file:lineno: msg" and "file:lineno:colno: msg" formats with a
regex. The old could would throw exceptions in certian cases, causing
the error messages to be hidden.
1bcb82d
@yiding yiding run hlint with working dir set to project dir
This seems to be a more sensible choice than the file's directory and
allows HLint hint files to be specified on the project root.
903fefd
@JPMoresmau JPMoresmau merged commit 828208d into JPMoresmau:master Jan 9, 2013
@JPMoresmau
Owner

Thanks a lot, changes merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.