Replace WaveBuilder by Smart Wave #114

Closed
sbordes opened this Issue May 14, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@sbordes
Member

sbordes commented May 14, 2014

Avoid all builders (complex to write) and update WaveBase to add chainable method.

Before:
ShowModelWaveBuilder.create()
.childrenPlaceHolder(this.application.getRootNode().getChildren())
.showModelKey(getFacade().getUiFacade().buildKey((Class) this.application.getFirstModelClass()))
.build();

After:
WaveBase.create()
.relatedClass(ShowModelCommand.class)
.waveGroup(CALL_COMMAND)
.waveBean(
DisplayWaveBean.create()
.childrenPlaceHolder(this.application.getRootNode().getChildren())
.showModelKey(getFacade().getUiFacade().buildKey((Class) this.application.getFirstModelClass())
);
Longer but the showModelWaveBuilder is removed and could be replaced by a simple method returning :
WaveBase.create()
.relatedClass(ShowModelCommand.class)
.waveGroup(CALL_COMMAND)

@sbordes sbordes added this to the 8.0.0 milestone May 14, 2014

@sbordes sbordes self-assigned this May 14, 2014

@sbordes sbordes added the enhancement label May 22, 2014

@sbordes sbordes closed this May 27, 2014

@sbordes

This comment has been minimized.

Show comment
Hide comment
@sbordes

sbordes May 27, 2014

Member

Pushed on Workbench branch

Member

sbordes commented May 27, 2014

Pushed on Workbench branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment