Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Undefined waves are consumed before all handlers (running into JTP and JAT) are processed #137
Saw in the processUndefinedWave() method from NotifierBase class:
LOGGER.info(NOTIFIER_CONSUMES, wave.toString()); wave.status(Status.Consumed);
The wave is notified as consumed after all handlers are executed. But it not takes the execution thread into consideration. It means all WaveHandler running into JIT (where the wave is processed) will be executed before the wave status is set to "Consumed" whereas others handlers could be executed after.
Here is a concrete example:
Until now my interpretation of the status consumed was: "The wave has permit to execute a method and this method has terminated". If it's this case there is maybe a bug into the framework.
I'm hesitating since I've seen theses two sentences in the official documentation:
Yes all handlers are correctly executed.
But I could not say if it was a bug or a normal thing because of my two interpretations I told in the first post.
I will consider it as a bug because the wave status should take on consideration all possible handler.
So I will create a maintenance 7.7.6 version, with backport of #126, do you need something else to migrate to 7.7.6.
[The 8.0.0 is ready but I'm performing a lot of refactoring before freezing the API.]
It's not essential to me to include it as quick as you can (but for others developpers it will be a good thing of course :)). We will not probably upgrade to 7.7.6 soon due to others projects we have. Maybe in few weeks.
As I remember no others issues are blocker for this.
Thanks a lot for this quick fix and your nice job !