Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
To be able to extend DisplayModelWaveBean. #153
We decided to migrate from the very very very old Jrebirth 7.7.0 to 8.0.2 this week, a good refresh for the project :)
Here is the first one.
But in Jrebirth 8.0.2 the DisplayModelWaveBean can not be extended anymore (since the constructor has become private).
Here are some ideas :
It will be interesting to have your opinion on this method. I can provide you an example with Jrebirth 7.7.0 if necessary.
Gloups, I have closed the api too late, the DMWB should not be specialized because it's used by internal methods (displayUI, that can be triggered from Wave)., but I understand your needs to add cool ergonomic features to this basic behavior.
I don't know yet the best way to add features to internal-commands, perhaps by adding hooks to call other commands between the prepare-show steps.
I don't know how deep are your changes, so if you have piece of code it could help
Using wave datas can be a solution, I will try this way for now and show you the result.
The WaveBean : http://pastebin.com/BWp2LiBs
Yes this is their goals (wrapping a lot of properties).
I will update the DMWB constructor visibility to protected, to let customization possible but I will do something to be able to customize the basic behavior by using a specialized DMWB (recopied into dispalyUi internal method)
Thus it will be possible to subclass DMWB to add a lot of properties and command hook will be added into ShowModelCommand.
added a commit
Aug 6, 2015
DisplayModelWaveBean 's Constructor has been reset to private because definitely it's not a good thing to specialize it.
Instead, I have refactored the WaveBean code. Now a wave can handle several WaveBean (one per type). Command can still have a dedicated WaveBean (even if code can be slightly improved to detect the kind).
The attachUi method was fixed and can call another command than ShowModelCommand, a sample is provided within MasteringTables application.
The new Grouped Command
And the fading command