New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key.create() can instanciate a classKey if the first KeyPart is empty #154

Closed
Rizen59 opened this Issue Jul 21, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@Rizen59
Contributor

Rizen59 commented Jul 21, 2015

I'd like to take about a line of code in Key.java

if (keyPart == null || keyPart.length == 0 || keyPart[0].toString().isEmpty())

If the first keyPart toString() is empty a ClassKey will be instanciate, and in the case of AbstractObjectModel model the method getObject() will not be able to retrieve the given keyPart.

I remember we already talk about this subject, but I can't find the message anymore (I think I have commented in a diff). On the other hand I found the corresponding commit : 2b791a5

Is it a regression issue?
Why check the first keyPart?

@sbordes sbordes self-assigned this Jul 21, 2015

@sbordes sbordes added this to the 8.1.0 milestone Jul 21, 2015

@sbordes sbordes added the regression label Jul 21, 2015

@sbordes

This comment has been minimized.

Show comment
Hide comment
@sbordes

sbordes Jul 21, 2015

Member

It's a regression check this commit : 2b791a5 to re apply the fix

Available into 8.0.3-SNAPSHOT on OJO

Member

sbordes commented Jul 21, 2015

It's a regression check this commit : 2b791a5 to re apply the fix

Available into 8.0.3-SNAPSHOT on OJO

sbordes added a commit that referenced this issue Jul 21, 2015

@sbordes sbordes modified the milestones: 8.0.3, 8.1.0 Jul 21, 2015

@sbordes sbordes closed this Jul 21, 2015

sbordes added a commit that referenced this issue Jul 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment