Add gradle support to 'processor' module #199

Closed
asafalima opened this Issue Jul 17, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@asafalima
Contributor

asafalima commented Jul 17, 2016

Now you can only use the processor module with maven,
Need to make some changes in 'ComponentProcessor' class to make it work with gradle.

Need to consider if we want to continue create the module starter class with the project group and artifactId or add new setting to 'jrebirth.properties' file.

Maybe make the properties in 'jrebirth.properties' the default source of the package and module name and then use the maven pom.xml file as a fallback.

@sbordes

This comment has been minimized.

Show comment
Hide comment
@sbordes

sbordes Jul 21, 2016

Member

Thanks for the contribution !

I will perform some tests and then close this issue

Member

sbordes commented Jul 21, 2016

Thanks for the contribution !

I will perform some tests and then close this issue

@sbordes sbordes added this to the 8.5.0 milestone Jul 21, 2016

@sbordes sbordes added the enhancement label Jul 21, 2016

@sbordes sbordes self-assigned this Jul 21, 2016

@asafalima

This comment has been minimized.

Show comment
Hide comment
@asafalima

asafalima Aug 6, 2016

Contributor

I submitted a pull request (#201) that fixes a bug that was still happening when building with gradle.

Now when you want to build using gradle you need to add the following lines to your build.gradle file:

dependencies {
  compile 'org.jrebirth.af:processor:8.5.0-SNAPSHOT'
  compile files('src/main/resources')
}

Another way is to add the processor module only when compiling the project:

configurations { providedCompile }
dependencies {
  providedCompile 'org.jrebirth.af:processor:8.5.0-SNAPSHOT'
  providedCompile files("src/main/resources")
}
sourceSets.main.compileClasspath += configurations.providedCompile
sourceSets.test.compileClasspath += configurations.providedCompile
Contributor

asafalima commented Aug 6, 2016

I submitted a pull request (#201) that fixes a bug that was still happening when building with gradle.

Now when you want to build using gradle you need to add the following lines to your build.gradle file:

dependencies {
  compile 'org.jrebirth.af:processor:8.5.0-SNAPSHOT'
  compile files('src/main/resources')
}

Another way is to add the processor module only when compiling the project:

configurations { providedCompile }
dependencies {
  providedCompile 'org.jrebirth.af:processor:8.5.0-SNAPSHOT'
  providedCompile files("src/main/resources")
}
sourceSets.main.compileClasspath += configurations.providedCompile
sourceSets.test.compileClasspath += configurations.providedCompile
@sbordes

This comment has been minimized.

Show comment
Hide comment
@sbordes

sbordes Aug 8, 2016

Member

Thanks for the extra explanation, I should create a special documentation page related to modularization

Member

sbordes commented Aug 8, 2016

Thanks for the extra explanation, I should create a special documentation page related to modularization

@sbordes

This comment has been minimized.

Show comment
Hide comment
@sbordes

sbordes Aug 9, 2016

Member

I haven't seen any trouble ins basic maven build (Demo Application) so I close the issue, but documentation should be added (ie: with a sample gradle project)

Member

sbordes commented Aug 9, 2016

I haven't seen any trouble ins basic maven build (Demo Application) so I close the issue, but documentation should be added (ie: with a sample gradle project)

@sbordes sbordes closed this Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment