New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaveListeners never notified on cancelled and destroyed #207

Closed
kevinsdooapp opened this Issue Oct 26, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@kevinsdooapp
Contributor

kevinsdooapp commented Oct 26, 2016

In classe WaveBase, in case of the wave status changes to Cancelled or Destroyed, WaveListeners will never be notified.

You'll find a fix in pull request

kevinsdooapp added a commit to kevinsdooapp/JRebirth that referenced this issue Oct 26, 2016

@sbordes sbordes added this to the 8.5.1 milestone Oct 26, 2016

@sbordes sbordes added the bug label Oct 26, 2016

kevinsdooapp added a commit to kevinsdooapp/JRebirth that referenced this issue Oct 26, 2016

kevinsdooapp added a commit to kevinsdooapp/JRebirth that referenced this issue Oct 26, 2016

@sbordes

This comment has been minimized.

Member

sbordes commented Oct 26, 2016

Fixed by PR #209

@sbordes sbordes closed this Oct 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment