New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave are marked handled before all handlers have terminated #218

Closed
sbordes opened this Issue Jan 27, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@sbordes
Member

sbordes commented Jan 27, 2017

I think that's a regression introduced by a Pull Request (083f62d)

The wave shall be marked as handled only when all handlers have terminated their jobs.

But sometimes the list of WaveHandler copied into the wave contains WaveHandler not elligible due to WaveChecker, in this case the list is never empty and the wave never marked as handled.

@sbordes sbordes added the regression label Jan 27, 2017

@sbordes sbordes added this to the 8.6.0 milestone Jan 27, 2017

@sbordes sbordes self-assigned this Jan 27, 2017

@sbordes sbordes closed this in 5f48a2d Jan 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment