New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskTrackerService is broken #86

Closed
amischler opened this Issue Nov 26, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@amischler
Copy link

amischler commented Nov 26, 2013

With JRebirth 0.7.6 (btw, tanks for the release!), the task tracking service is broken:

16:39:54.939 [JIT] ERROR com.dooapp.dsdkcore.DsdkApplication - Task must only be used from the FX Application Thread
java.lang.IllegalStateException: Task must only be used from the FX Application Thread
    at javafx.concurrent.Task.checkThread(Task.java:1219) ~[jfxrt.jar:na]
    at javafx.concurrent.Task.setOnCancelled(Task.java:900) ~[jfxrt.jar:na]
    at org.jrebirth.core.service.basic.TaskTrackerService.trackTask(TaskTrackerService.java:76) ~[core-0.7.6.jar:na]
    at org.jrebirth.core.link.NotifierBase.returnData(NotifierBase.java:171) ~[core-0.7.6.jar:na]
    at org.jrebirth.core.link.NotifierBase.sendWave(NotifierBase.java:103) ~[core-0.7.6.jar:na]
    at org.jrebirth.core.link.AbstractWaveReady$3.runInto(AbstractWaveReady.java:231) ~[core-0.7.6.jar:na]
    at org.jrebirth.core.concurrent.AbstractJrbRunnable.run(AbstractJrbRunnable.java:78) ~[core-0.7.6.jar:na]
    at org.jrebirth.core.concurrent.JRebirthThread.run(JRebirthThread.java:172) ~[core-0.7.6.jar:na]

@ghost ghost assigned sbordes Nov 26, 2013

@sbordes

This comment has been minimized.

Copy link
Member

sbordes commented Nov 26, 2013

Can you confirm me that it was working with 0.7.5 version ?

Because code didn't change and sure there is a lack when using FOLLOW_UP_SERVICE_TASKS parameter with true, returnData method is called from JIT and javafx.Task require to manage it into JAT...

I will fix it by listening wave status instead and by linking task state with current wave processed status.

@amischler

This comment has been minimized.

Copy link
Author

amischler commented Nov 27, 2013

It worked with the 0.7.5-SNAPSHOT - I didn't try with the 0.7.5 because of the JTP issue.

@sbordes

This comment has been minimized.

Copy link
Member

sbordes commented Nov 27, 2013

So it's probably a nasty side-effect seen as a regression into 0.7.5.

I will reveiwed this part to be independant of the checkJAT done by toolkit

@sbordes

This comment has been minimized.

Copy link
Member

sbordes commented Dec 10, 2013

I didn't reproduce the problem,

Which Java[FX] version are you using ?

Here my stack without any exception thrown with jdk 1.7.0_40 & 1.7.0_45

Daemon Thread [JIT](Suspended %28breakpoint at line 76 in TaskTrackerService%29)
TaskTrackerService.trackTask(ServiceTask<?>) line: 76
NotifierBase.returnData(Wave) line: 171
NotifierBase.sendWave(Wave) line: 103
AbstractWaveReady$3.runInto() line: 231
AbstractWaveReady$3(AbstractJrbRunnable).run() line: 78
JRebirthThread.run() line: 172

@sbordes sbordes closed this Jan 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment