New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getThirdKeyPart() method that was currently returning the second one #203

Merged
merged 1 commit into from Sep 8, 2016

Conversation

Projects
None yet
2 participants
@Rizen59
Contributor

Rizen59 commented Sep 8, 2016

No description provided.

@sbordes sbordes merged commit a117984 into JRebirth:8.x-dev Sep 8, 2016

@sbordes

This comment has been minimized.

Show comment
Hide comment
@sbordes

sbordes Sep 8, 2016

Member

Thanks for the PR, apparently you are the first to use 3 key parts !

Member

sbordes commented Sep 8, 2016

Thanks for the PR, apparently you are the first to use 3 key parts !

@sbordes

This comment has been minimized.

Show comment
Hide comment
@sbordes

sbordes Sep 8, 2016

Member

Build done, 8.5.0-SNAPSHOT available on ojo oss.jfrog.org

Member

sbordes commented Sep 8, 2016

Build done, 8.5.0-SNAPSHOT available on ojo oss.jfrog.org

@Rizen59

This comment has been minimized.

Show comment
Hide comment
@Rizen59

Rizen59 Sep 9, 2016

Contributor

Thanks for the PR, apparently you are the first to use 3 key parts !

A such case does not happen every day. Thanks for the quick merge. When do you plan to release the next version ?

Contributor

Rizen59 commented Sep 9, 2016

Thanks for the PR, apparently you are the first to use 3 key parts !

A such case does not happen every day. Thanks for the quick merge. When do you plan to release the next version ?

@sbordes

This comment has been minimized.

Show comment
Hide comment
@sbordes

sbordes Sep 9, 2016

Member

The build is ready but I have experienced terrible trouble when publishing the site throught SCP (ssh negotation fails ((Error uploading site: Cannot connect. Reason: Algorithm negotiation fail))and I don't if the problem comes from remote server or ci one), so I plan to release 8.5.0 soon (perhaps this WE) and publish manually the site

Member

sbordes commented Sep 9, 2016

The build is ready but I have experienced terrible trouble when publishing the site throught SCP (ssh negotation fails ((Error uploading site: Cannot connect. Reason: Algorithm negotiation fail))and I don't if the problem comes from remote server or ci one), so I plan to release 8.5.0 soon (perhaps this WE) and publish manually the site

@sbordes sbordes added the bug label Sep 9, 2016

@sbordes sbordes added this to the 8.5.0 milestone Sep 9, 2016

@sbordes sbordes self-assigned this Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment