Competitive Ruleset + QoL toggles (rebased from #196)#202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #196 by @the-outcaster — adds a Competitive Ruleset toggle and several QoL settings under Settings → Gameplay:
Decomp side
Pairs with decomp PR JRickey/ssb-decomp-re#5 (the C-side hooks). Decomp pointer bumped to
d208de7b9— that commit is the rebased version of PR #5 sitting on top of currentport-patches, pushed to theagent/comp-rulesetbranch onJRickey/ssb-decomp-re. After this PR merges,port-patchesshould be fast-forwarded to that SHA and decomp PR #5 closed.Conflict resolution
Inputsidebar at the same spot. Resolved by placing Competitive Ruleset + QoL widgets first (they stay in theGameplaysidebar with the existingpath), then theInputsidebar transition. Functionally identical to merging them independently.Build-verified on Windows (MSVC).
Closes #196
Co-authored-by: the-outcaster linuxgamingcentral@pm.me