From 8f6d78b147f4958d3ee5c39d6ea3b774cf713898 Mon Sep 17 00:00:00 2001 From: joaovictor91123 Date: Fri, 24 Jul 2026 19:34:22 +0400 Subject: [PATCH] fix(ci): stop swallowing control-plane coverage failures with an unjustified || true The REES coverage step's identical || true is documented and justified (c8 instrumentation inflates its timing-sensitive assertions past their uninstrumented budgets). Control-plane's suite has no such timing-budget or ReDoS-guard assertions, so this looks like the shape being copied without its justification, not a verified decision. A genuine coverage-harvest failure that still writes a non-empty but incomplete/wrong lcov.info currently stays green and uploads bad data to Codecov -- exactly what the next step's existence check is meant to catch but, with the swallow in place, cannot. Verified locally: after rebuilding control-plane (stale dist), npm run control-plane:coverage exits 0 with all 201 tests passing and a clean coverage summary, confirming the swallow is safe to remove. Closes #8392 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b47d47430..438cdc162 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -649,7 +649,7 @@ jobs: run: npm run control-plane:test - name: Control-plane coverage if: ${{ github.event_name == 'push' || needs.changes.outputs.controlPlane == 'true' }} - run: npm run control-plane:coverage || true + run: npm run control-plane:coverage - name: Verify control-plane coverage report exists if: ${{ github.event_name == 'push' || needs.changes.outputs.controlPlane == 'true' }} run: |