memory_card: fixed off by one in card numbering

JaCzekanski · Nov 18, 2021 · dd517d8 · dd517d8
1 parent b568e67
commit dd517d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/device/controller/peripherals/abstract_device.h b/src/device/controller/peripherals/abstract_device.h
@@ -5,7 +5,7 @@ namespace peripherals {
 enum class Type { None, Digital, Analog, Mouse, MemoryCard };
 struct AbstractDevice {
     Type type;
-    int port;  // Physical port number
+    int port;  // Physical port number (numbered from 1..n)
     int state = 0;
 
     AbstractDevice(Type type, int port);

diff --git a/src/device/controller/peripherals/memory_card.cpp b/src/device/controller/peripherals/memory_card.cpp
@@ -150,7 +150,7 @@ uint8_t MemoryCard::handleWrite(uint8_t byte) {
             state = 0;
             command = Command::None;
 
-            bus.notify(Event::Controller::MemoryCardContentsChanged{port});
+            bus.notify(Event::Controller::MemoryCardContentsChanged{port - 1});
 
             return static_cast<uint8_t>(writeStatus);