diff --git a/CHANGELOG.md b/CHANGELOG.md index 3ace7046089..1067763a760 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,12 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# ## [Unreleased] ### Changed +- We changed the location of some fields in the entry editor (you might need to reset your preferences for these changes to come into effect) + - Journal/Year/Month in biblatex mode -> Deprecated (if filled) + - DOI/URL: General -> Optional + - Internal fields like ranking, read status and priority: Other -> General + - Moreover, empty deprecated fields are no longer shown +- Added server timezone parameter when connecting to a shared database. - We updated the dialog for setting up general fields. - URL field formatting is updated. All whitespace chars, located at the beginning/ending of the url, are trimmed automatically - We changed the behavior of the field formatting dialog such that the `bibtexkey` is not changed when formatting all fields or all text fields. diff --git a/build.gradle b/build.gradle index 24665d8c2be..f364470d047 100644 --- a/build.gradle +++ b/build.gradle @@ -157,8 +157,8 @@ dependencies { errorproneJavac 'com.google.errorprone:javac:1.8.0-u20' - compile group: 'com.microsoft.azure', name: 'applicationinsights-core', version: '2.2.0' - compile group: 'com.microsoft.azure', name: 'applicationinsights-logging-log4j2', version: '2.2.0' + compile group: 'com.microsoft.azure', name: 'applicationinsights-core', version: '2.2.1' + compile group: 'com.microsoft.azure', name: 'applicationinsights-logging-log4j2', version: '2.2.1' testImplementation 'org.junit.jupiter:junit-jupiter-api:5.3.1' testCompile 'org.junit.jupiter:junit-jupiter-params:5.3.1' @@ -174,8 +174,8 @@ dependencies { testCompile 'org.reflections:reflections:0.9.11' testCompile 'org.xmlunit:xmlunit-core:2.6.2' testCompile 'org.xmlunit:xmlunit-matchers:2.6.2' - testCompile 'com.tngtech.archunit:archunit-junit5-api:0.9.1' - testRuntime 'com.tngtech.archunit:archunit-junit5-engine:0.9.1' + testCompile 'com.tngtech.archunit:archunit-junit5-api:0.9.2' + testRuntime 'com.tngtech.archunit:archunit-junit5-engine:0.9.2' testCompile "org.testfx:testfx-core:4.0.+" testCompile "org.testfx:testfx-junit5:4.0.+" diff --git a/src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java b/src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java index 3b3c1c66438..2e372e7a42c 100644 --- a/src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java +++ b/src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java @@ -1,6 +1,7 @@ package org.jabref.gui.entryeditor; import java.util.Collection; +import java.util.stream.Collectors; import javax.swing.undo.UndoManager; @@ -25,6 +26,9 @@ public DeprecatedFieldsTab(BibDatabaseContext databaseContext, SuggestionProvide @Override protected Collection determineFieldsToShow(BibEntry entry, EntryType entryType) { - return entryType.getDeprecatedFields(); + return entryType.getDeprecatedFields() + .stream() + .filter(entry::hasField) + .collect(Collectors.toList()); } } diff --git a/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java b/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java index 60d43a613cb..ecd1d7e6a2f 100644 --- a/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java +++ b/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java @@ -163,7 +163,14 @@ public boolean save() { panel.frame().output(Localization.lang("Saving library") + "..."); panel.setSaving(true); return doSave(); + } else { + Optional savePath = getSavePath(); + if (savePath.isPresent()) { + saveAs(savePath.get()); + return true; + } } + return false; } diff --git a/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialog.fxml b/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialog.fxml index c8c3d49729c..30808026c50 100644 --- a/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialog.fxml +++ b/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialog.fxml @@ -52,6 +52,8 @@