From 1f6b67b481d84732cdf3f17f21868bc059627991 Mon Sep 17 00:00:00 2001 From: Oscar Gustafsson Date: Sun, 6 Dec 2015 18:22:04 +0100 Subject: [PATCH] Maybe working now? --- src/main/java/net/sf/jabref/sql/DbConnectAction.java | 7 ++++--- src/main/java/net/sf/jabref/sql/SQLUtil.java | 5 ++--- .../net/sf/jabref/sql/importer/PostgreSQLImporter.java | 7 +++---- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/main/java/net/sf/jabref/sql/DbConnectAction.java b/src/main/java/net/sf/jabref/sql/DbConnectAction.java index 49e4a87c910..9d416baf93b 100644 --- a/src/main/java/net/sf/jabref/sql/DbConnectAction.java +++ b/src/main/java/net/sf/jabref/sql/DbConnectAction.java @@ -71,7 +71,7 @@ public void action() { PositionWindow.placeDialog(dbd, panel); dbd.setVisible(true); - // connnect to database to test DBStrings + // connect to database to test DBStrings if (dbd.getConnectToDB()) { dbs = dbd.getDBStrings(); @@ -82,8 +82,9 @@ public void action() { Localization.lang("Establishing SQL connection...")); DBExporter exporter = (new DBExporterAndImporterFactory()) .getExporter(dbs.getServerType()); - Connection conn = exporter.connectToDB(dbs); - conn.close(); + try (Connection conn = exporter.connectToDB(dbs)) { + // Nothing + } dbs.isConfigValid(true); panel.frame().output( Localization.lang("SQL connection established.")); diff --git a/src/main/java/net/sf/jabref/sql/SQLUtil.java b/src/main/java/net/sf/jabref/sql/SQLUtil.java index e3d00505a6b..b55b109e5ea 100644 --- a/src/main/java/net/sf/jabref/sql/SQLUtil.java +++ b/src/main/java/net/sf/jabref/sql/SQLUtil.java @@ -186,9 +186,8 @@ public static String getExceptionMessage(Exception ex) { */ public static ResultSet queryAllFromTable(Connection conn, String tableName) throws SQLException { String query = "SELECT * FROM " + tableName + ';'; - try (Statement res = (Statement) SQLUtil.processQueryWithResults(conn, query)) { - return res.getResultSet(); - } + Statement res = (Statement) SQLUtil.processQueryWithResults(conn, query); + return res.getResultSet(); } /** diff --git a/src/main/java/net/sf/jabref/sql/importer/PostgreSQLImporter.java b/src/main/java/net/sf/jabref/sql/importer/PostgreSQLImporter.java index cd91a52277a..2a5c0e0ab15 100644 --- a/src/main/java/net/sf/jabref/sql/importer/PostgreSQLImporter.java +++ b/src/main/java/net/sf/jabref/sql/importer/PostgreSQLImporter.java @@ -53,10 +53,9 @@ public static PostgreSQLImporter getInstance() { @Override protected ResultSet readColumnNames(Connection conn) throws SQLException { - try (Statement statement = (Statement) SQLUtil.processQueryWithResults(conn, - "SELECT column_name FROM information_schema.columns WHERE table_name ='entries';")) { - return statement.getResultSet(); - } + Statement statement = (Statement) SQLUtil.processQueryWithResults(conn, + "SELECT column_name FROM information_schema.columns WHERE table_name ='entries';"); + return statement.getResultSet(); } @Override