diff --git a/CHANGELOG.md b/CHANGELOG.md index 3727109cfd4..18516649af7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,9 +15,10 @@ to [sourceforge feature requests](https://sourceforge.net/p/jabref/features/) by ### Changed ### Fixed +- Fixed [#666](https://github.com/JabRef/jabref/issues/666): MS Office 2007 export is working again ### Removed - +- Fixed [#627](https://github.com/JabRef/jabref/issues/627): The pdf field is removed from the export formats, use the file field @@ -45,9 +46,6 @@ to [sourceforge feature requests](https://sourceforge.net/p/jabref/features/) by ### Fixed - Changes in customized entry types are now directly reflected in the table when clicking "Apply" or "OK" -- Fixed [#593](https://github.com/JabRef/jabref/issues/593): Reference list generation works for OpenOffice/LibreOffice again -- Fixed [#545](https://github.com/JabRef/jabref/issues/545): ACM fetcher works again -- Fixed [#598](https://github.com/JabRef/jabref/issues/598): Use default file icon for custom external file types - Fixed [#608](https://github.com/JabRef/jabref/issues/608): Export works again - Fixed [#417](https://github.com/JabRef/jabref/issues/417): Table now updates when switching groups - Fixed [#534](https://github.com/JabRef/jabref/issues/534): No OpenOffice setup panel in preferences diff --git a/src/main/java/net/sf/jabref/exporter/ExportFormat.java b/src/main/java/net/sf/jabref/exporter/ExportFormat.java index cc08ef36132..3fb1045771c 100644 --- a/src/main/java/net/sf/jabref/exporter/ExportFormat.java +++ b/src/main/java/net/sf/jabref/exporter/ExportFormat.java @@ -201,7 +201,7 @@ public void performExport(final BibDatabase database, // Set a global field, so all layouts have access to the custom name formatters: Globals.prefs.customExportNameFormatters = readFormatterFile(lfFileName); - ArrayList missingFormatters = new ArrayList<>(1); + List missingFormatters = new ArrayList<>(1); // Print header try (Reader reader = getReader(lfFileName + ".begin.layout")) { @@ -235,7 +235,9 @@ public void performExport(final BibDatabase database, } if (defLayout != null) { missingFormatters.addAll(defLayout.getMissingFormatters()); - LOGGER.warn(defLayout.getMissingFormatters()); + if (!missingFormatters.isEmpty()) { + LOGGER.warn(missingFormatters); + } } HashMap layouts = new HashMap<>(); Layout layout; diff --git a/src/main/java/net/sf/jabref/exporter/MSBibExportFormat.java b/src/main/java/net/sf/jabref/exporter/MSBibExportFormat.java index c487848e18b..50db4faddca 100644 --- a/src/main/java/net/sf/jabref/exporter/MSBibExportFormat.java +++ b/src/main/java/net/sf/jabref/exporter/MSBibExportFormat.java @@ -61,13 +61,9 @@ public void performExport(final BibDatabase database, final MetaData metaData, f } catch (Exception e) { throw new Error(e); } - } - try { finalizeSaveSession(ss); - } catch (SaveException ex) { + } catch (Exception ex) { throw new IOException(ex.getMessage()); - } catch (Exception e) { - throw new IOException(e.getMessage()); } } } diff --git a/src/main/java/net/sf/jabref/exporter/ModsExportFormat.java b/src/main/java/net/sf/jabref/exporter/ModsExportFormat.java index 292287af508..f112dba82ff 100644 --- a/src/main/java/net/sf/jabref/exporter/ModsExportFormat.java +++ b/src/main/java/net/sf/jabref/exporter/ModsExportFormat.java @@ -45,25 +45,21 @@ public void performExport(final BibDatabase database, final MetaData metaData, final String file, final Charset encoding, Set keySet) throws IOException { SaveSession ss = getSaveSession(StandardCharsets.UTF_8, new File(file)); - VerifyingWriter ps = ss.getWriter(); - MODSDatabase md = new MODSDatabase(database, keySet); + try (VerifyingWriter ps = ss.getWriter()) { + MODSDatabase md = new MODSDatabase(database, keySet); - try { - DOMSource source = new DOMSource(md.getDOMrepresentation()); - StreamResult result = new StreamResult(ps); - Transformer trans = TransformerFactory.newInstance().newTransformer(); - trans.setOutputProperty(OutputKeys.INDENT, "yes"); - trans.transform(source, result); - } catch (Exception e) { - throw new Error(e); - } - - try { + try { + DOMSource source = new DOMSource(md.getDOMrepresentation()); + StreamResult result = new StreamResult(ps); + Transformer trans = TransformerFactory.newInstance().newTransformer(); + trans.setOutputProperty(OutputKeys.INDENT, "yes"); + trans.transform(source, result); + } catch (Exception e) { + throw new Error(e); + } finalizeSaveSession(ss); - } catch (SaveException ex) { + } catch (Exception ex) { throw new IOException(ex.getMessage()); - } catch (Exception e) { - throw new IOException(e.getMessage()); } } } diff --git a/src/main/java/net/sf/jabref/exporter/OpenDocumentSpreadsheetCreator.java b/src/main/java/net/sf/jabref/exporter/OpenDocumentSpreadsheetCreator.java index 38e00ee4f7c..49394c71251 100644 --- a/src/main/java/net/sf/jabref/exporter/OpenDocumentSpreadsheetCreator.java +++ b/src/main/java/net/sf/jabref/exporter/OpenDocumentSpreadsheetCreator.java @@ -104,19 +104,16 @@ private static void exportOpenDocumentSpreadsheet(File file, BibDatabase databas private static void exportOpenDocumentSpreadsheetXML(File tmpFile, BibDatabase database, Set keySet) { OpenDocumentRepresentation od = new OpenDocumentRepresentation(database, keySet); - try { - try (Writer ps = new OutputStreamWriter(new FileOutputStream(tmpFile), StandardCharsets.UTF_8)) { - - DOMSource source = new DOMSource(od.getDOMrepresentation()); - StreamResult result = new StreamResult(ps); - Transformer trans = TransformerFactory.newInstance().newTransformer(); - trans.setOutputProperty(OutputKeys.INDENT, "yes"); - trans.transform(source, result); - } + try (Writer ps = new OutputStreamWriter(new FileOutputStream(tmpFile), StandardCharsets.UTF_8)) { + + DOMSource source = new DOMSource(od.getDOMrepresentation()); + StreamResult result = new StreamResult(ps); + Transformer trans = TransformerFactory.newInstance().newTransformer(); + trans.setOutputProperty(OutputKeys.INDENT, "yes"); + trans.transform(source, result); } catch (Exception e) { throw new Error(e); } - } private static void addResourceFile(String name, String resource, ZipOutputStream out) throws IOException { diff --git a/src/main/resources/resource/layout/bibtexml.layout b/src/main/resources/resource/layout/bibtexml.layout index 62eb6811e4e..da4dbae0e90 100644 --- a/src/main/resources/resource/layout/bibtexml.layout +++ b/src/main/resources/resource/layout/bibtexml.layout @@ -23,7 +23,6 @@ \begin{url} \format[XMLChars]{\url}\end{url} \begin{doi} \format[XMLChars]{\doi}\end{doi} \begin{eid} \format[XMLChars]{\eid}\end{eid} -\begin{pdf} \format[ResolvePDF,XMLChars]{\pdf}\end{pdf} \begin{type} \format[XMLChars]{\type}\end{type} \begin{crossref} \format[XMLChars]{\crossref}\end{crossref} \begin{annote} \format[XMLChars]{\annote}\end{annote} diff --git a/src/main/resources/resource/layout/endnote/EndNote.article.layout b/src/main/resources/resource/layout/endnote/EndNote.article.layout index f52bee1b8c0..3f1c79ec2f2 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.article.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.article.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 article diff --git a/src/main/resources/resource/layout/endnote/EndNote.book.layout b/src/main/resources/resource/layout/endnote/EndNote.book.layout index 92cb46b809c..7b1defd2344 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.book.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.book.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 book diff --git a/src/main/resources/resource/layout/endnote/EndNote.booklet.layout b/src/main/resources/resource/layout/endnote/EndNote.booklet.layout index 9635c2dd97e..038ae6df82e 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.booklet.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.booklet.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 booklet diff --git a/src/main/resources/resource/layout/endnote/EndNote.inbook.layout b/src/main/resources/resource/layout/endnote/EndNote.inbook.layout index dca0ff3e0a1..c682ba8b985 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.inbook.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.inbook.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 inbook diff --git a/src/main/resources/resource/layout/endnote/EndNote.incollection.layout b/src/main/resources/resource/layout/endnote/EndNote.incollection.layout index 0956822d560..30a8db59069 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.incollection.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.incollection.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 incollection diff --git a/src/main/resources/resource/layout/endnote/EndNote.inproceedings.layout b/src/main/resources/resource/layout/endnote/EndNote.inproceedings.layout index 7ca4100d0e8..0448e5ba59d 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.inproceedings.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.inproceedings.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 inproceedings diff --git a/src/main/resources/resource/layout/endnote/EndNote.layout b/src/main/resources/resource/layout/endnote/EndNote.layout index 3ef5296830e..5fe909fed9d 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 \entrytype diff --git a/src/main/resources/resource/layout/endnote/EndNote.manual.layout b/src/main/resources/resource/layout/endnote/EndNote.manual.layout index 084b94e553a..04274a5bd79 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.manual.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.manual.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 manual diff --git a/src/main/resources/resource/layout/endnote/EndNote.mastersthesis.layout b/src/main/resources/resource/layout/endnote/EndNote.mastersthesis.layout index 86af2d95ff6..11d055611b1 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.mastersthesis.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.mastersthesis.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 mastersthesis diff --git a/src/main/resources/resource/layout/endnote/EndNote.misc.layout b/src/main/resources/resource/layout/endnote/EndNote.misc.layout index 7df4a946d09..3b3c7f0d00b 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.misc.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.misc.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 misc diff --git a/src/main/resources/resource/layout/endnote/EndNote.other.layout b/src/main/resources/resource/layout/endnote/EndNote.other.layout index bd45e464063..e56070fce8c 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.other.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.other.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 other diff --git a/src/main/resources/resource/layout/endnote/EndNote.phdthesis.layout b/src/main/resources/resource/layout/endnote/EndNote.phdthesis.layout index 3fe2498e15d..2f09afdeed0 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.phdthesis.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.phdthesis.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 phdthesis diff --git a/src/main/resources/resource/layout/endnote/EndNote.proceedings.layout b/src/main/resources/resource/layout/endnote/EndNote.proceedings.layout index 9133c411721..bcc83f4ddf8 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.proceedings.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.proceedings.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 proceedings diff --git a/src/main/resources/resource/layout/endnote/EndNote.techreport.layout b/src/main/resources/resource/layout/endnote/EndNote.techreport.layout index 4a78bcb8a5d..3e275a17a59 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.techreport.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.techreport.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 techreport diff --git a/src/main/resources/resource/layout/endnote/EndNote.unpublished.layout b/src/main/resources/resource/layout/endnote/EndNote.unpublished.layout index 556fe117ae0..103f3778506 100644 --- a/src/main/resources/resource/layout/endnote/EndNote.unpublished.layout +++ b/src/main/resources/resource/layout/endnote/EndNote.unpublished.layout @@ -26,7 +26,6 @@ %* %L %M -\format[ResolvePDF,WrapContent(%1 ,)]{\pdf} \format[FileLink(pdf),WrapContent(%1 ,)]{\file} %2 \comment %3 unpublished diff --git a/src/main/resources/resource/layout/html.book.layout b/src/main/resources/resource/layout/html.book.layout index 4a848d29683..8e3922f4c94 100644 --- a/src/main/resources/resource/layout/html.book.layout +++ b/src/main/resources/resource/layout/html.book.layout @@ -11,12 +11,6 @@ \end{file} - \begin{pdf} -
- pdf -
- \end{pdf} - \begin{url}
url diff --git a/src/main/resources/resource/layout/html.inbook.layout b/src/main/resources/resource/layout/html.inbook.layout index 6eee6c470ae..fcb3d3fe736 100644 --- a/src/main/resources/resource/layout/html.inbook.layout +++ b/src/main/resources/resource/layout/html.inbook.layout @@ -23,12 +23,6 @@
\end{file} - \begin{pdf} -
- pdf -
- \end{pdf} - \begin{url}
url diff --git a/src/main/resources/resource/layout/html.inproceedings.layout b/src/main/resources/resource/layout/html.inproceedings.layout index 87c74af113d..0beb1407ef4 100644 --- a/src/main/resources/resource/layout/html.inproceedings.layout +++ b/src/main/resources/resource/layout/html.inproceedings.layout @@ -23,12 +23,6 @@
\end{file} - \begin{pdf} -
- pdf -
- \end{pdf} - \begin{url}
url diff --git a/src/main/resources/resource/layout/html.layout b/src/main/resources/resource/layout/html.layout index 69fff258263..f74dc6c4ed7 100644 --- a/src/main/resources/resource/layout/html.layout +++ b/src/main/resources/resource/layout/html.layout @@ -29,12 +29,6 @@
\end{file} - \begin{pdf} -
- pdf -
- \end{pdf} - \begin{url}
url diff --git a/src/main/resources/resource/layout/html.mastersthesis.layout b/src/main/resources/resource/layout/html.mastersthesis.layout index 813c31da5cd..cc7b92e22c2 100644 --- a/src/main/resources/resource/layout/html.mastersthesis.layout +++ b/src/main/resources/resource/layout/html.mastersthesis.layout @@ -11,12 +11,6 @@
\end{file} - \begin{pdf} -
- pdf -
- \end{pdf} - \begin{url}
url diff --git a/src/main/resources/resource/layout/html.phdthesis.layout b/src/main/resources/resource/layout/html.phdthesis.layout index 813c31da5cd..cc7b92e22c2 100644 --- a/src/main/resources/resource/layout/html.phdthesis.layout +++ b/src/main/resources/resource/layout/html.phdthesis.layout @@ -11,12 +11,6 @@
\end{file} - \begin{pdf} -
- pdf -
- \end{pdf} - \begin{url}
url diff --git a/src/main/resources/resource/layout/openoffice/openoffice-csv.layout b/src/main/resources/resource/layout/openoffice/openoffice-csv.layout index 467a31d5a6d..d50c93123e8 100644 --- a/src/main/resources/resource/layout/openoffice/openoffice-csv.layout +++ b/src/main/resources/resource/layout/openoffice/openoffice-csv.layout @@ -1 +1 @@ -\format[GetOpenOfficeType]{\bibtextype},"\begin{isbn}\isbn\end{isbn}","\bibtexkey","\format[AuthorLastFirst,AuthorAndsReplacer]{\author}","\format[RemoveBrackets,RemoveWhitespace]{\title}","\journal",\volume,\number,"\month","\pages",\year,"\address","\note","\url","\booktitle","\chapter","\edition","\series","\format[AuthorLastFirst,AuthorAndsReplacer]{\editor}","\publisher","\begin{reporttype}\reporttype\end{reporttype}","\howpublished","\institution","\organization","\school","\annote","\format[Replace(\n, )]{\abstract}","\comment","\keywords","\format[ResolvePDF]{\pdf}","\key" +\format[GetOpenOfficeType]{\bibtextype},"\begin{isbn}\isbn\end{isbn}","\bibtexkey","\format[AuthorLastFirst,AuthorAndsReplacer]{\author}","\format[RemoveBrackets,RemoveWhitespace]{\title}","\journal",\volume,\number,"\month","\pages",\year,"\address","\note","\url","\booktitle","\chapter","\edition","\series","\format[AuthorLastFirst,AuthorAndsReplacer]{\editor}","\publisher","\begin{reporttype}\reporttype\end{reporttype}","\howpublished","\institution","\organization","\school","\annote","\format[Replace(\n, )]{\abstract}","\comment","\keywords","\format[FileLink(pdf)]{\file}","\key"