From c67c395e4fd6d3cbb86effc8dd096fe94e0612cd Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Tue, 23 Nov 2021 22:47:33 +0100 Subject: [PATCH] Add saving finished notification --- CHANGELOG.md | 2 ++ src/main/java/org/jabref/gui/DialogService.java | 2 +- .../java/org/jabref/gui/exporter/SaveDatabaseAction.java | 1 + src/main/resources/l10n/JabRef_en.properties | 6 ++---- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9e5d2e2d74f..7a32c2c17bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,8 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve - We allowed the user to also preview the available citation styles in the preferences besides the selected ones [#8108](https://github.com/JabRef/jabref/issues/8108) - We added an option to search the available citation styles by name in the preferences [#8108](https://github.com/JabRef/jabref/issues/8108) - We added an option to generate bib-entries from ID through a popover in the toolbar. [#4183](https://github.com/JabRef/jabref/issues/4183) +- We added a menu option in the right click menu of the main table tabs to display the library properties. [#6527](https://github.com/JabRef/jabref/issues/6527) +- When a `.bib` file ("library") was saved successfully, a notification is shown ### Changed diff --git a/src/main/java/org/jabref/gui/DialogService.java b/src/main/java/org/jabref/gui/DialogService.java index 367b81bda0d..26cf46c00a1 100644 --- a/src/main/java/org/jabref/gui/DialogService.java +++ b/src/main/java/org/jabref/gui/DialogService.java @@ -215,7 +215,7 @@ Optional showCustomButtonDialogAndWait(Alert.AlertType type, String Optional showBackgroundProgressDialogAndWait(String title, String content, StateManager stateManager); /** - * Notify the user in an non-blocking way (i.e., in form of toast in a snackbar). + * Notify the user in a non-blocking way (i.e., in form of toast in a snackbar). * * @param message the message to show. */ diff --git a/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java b/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java index 5ae882116e9..c6bdf64e531 100644 --- a/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java +++ b/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java @@ -214,6 +214,7 @@ private boolean save(Path targetPath, SaveDatabaseMode mode) { libraryTab.getUndoManager().markUnchanged(); libraryTab.resetChangedProperties(); } + dialogService.notify(Localization.lang("Library saved")); return success; } catch (SaveException ex) { LOGGER.error(String.format("A problem occurred when trying to save the file %s", targetPath), ex); diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties index b2f0af29125..fca130b58fd 100644 --- a/src/main/resources/l10n/JabRef_en.properties +++ b/src/main/resources/l10n/JabRef_en.properties @@ -756,13 +756,11 @@ Save\ before\ closing=Save before closing Save\ library=Save library Save\ library\ as...=Save library as... - -Saved\ selected\ to\ '%0'.=Saved selected to '%0'. - Saving=Saving Saving\ all\ libraries...=Saving all libraries... - Saving\ library=Saving library +Library\ saved=Library saved +Saved\ selected\ to\ '%0'.=Saved selected to '%0'. Search=Search