New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for function: export the pdfs of all the selected entrys to a new folder #2539

Closed
Vaver opened this Issue Feb 14, 2017 · 14 comments

Comments

Projects
None yet
4 participants
@Vaver

Vaver commented Feb 14, 2017

some times, i want share some of the literature pdfs to friends, it is very easy to select the wanted entrys from the Jabref, but hard to pick out the seleted pdfs.

I hope there is a function to export the pdfs of the selected entrys to a new folder.

thanks

@AEgit

This comment has been minimized.

Show comment
Hide comment
@AEgit

AEgit Feb 16, 2017

I agree, that would a very nice feature to have. I guess, it is also already somewhat implemented in JabRef, as JabRef is already able to move files from one folder to another. Just copying (instead of moving) the files from one folder to another, user-specified folder would probably already do the trick, I guess.

AEgit commented Feb 16, 2017

I agree, that would a very nice feature to have. I guess, it is also already somewhat implemented in JabRef, as JabRef is already able to move files from one folder to another. Just copying (instead of moving) the files from one folder to another, user-specified folder would probably already do the trick, I guess.

@Siedlerchr Siedlerchr referenced this issue Apr 2, 2017

Closed

[WIP] Create PDF file Exporter #2706

1 of 6 tasks complete
@Siedlerchr

This comment has been minimized.

Show comment
Hide comment
@Siedlerchr

Siedlerchr Apr 5, 2017

Contributor

@Vaver @AEgit I have implemented the export functionality that works for all linked files:

http://builds.jabref.org/exportPDF/

Please beware that the current dev versions are still in alpha state and still miss some functionality.
Do a backup of your db before testing.

You can use it like any other export function. Select the entries then choose Export -> Files Exporter
However there is currently one thing I can not change: You have to enter an arbitrary string in the save dialog as "filename". The entered name is ignored, it is just needed to get the directory.

Contributor

Siedlerchr commented Apr 5, 2017

@Vaver @AEgit I have implemented the export functionality that works for all linked files:

http://builds.jabref.org/exportPDF/

Please beware that the current dev versions are still in alpha state and still miss some functionality.
Do a backup of your db before testing.

You can use it like any other export function. Select the entries then choose Export -> Files Exporter
However there is currently one thing I can not change: You have to enter an arbitrary string in the save dialog as "filename". The entered name is ignored, it is just needed to get the directory.

@AEgit

This comment has been minimized.

Show comment
Hide comment
@AEgit

AEgit Apr 5, 2017

@Siedlerchr : Thank you very much! I can confirm that this feature works in the posted build!

And immediately a warning or potential improvement due to (my) typical noob behaviour. I went for "Export" instead of "Export selected". This lead to JabRef copying over all linked files (in my case ~100 GB) - even when you stop JabRef, it will continue copying over those files. Only by killing the relevant process I was able to stop the copy process.
To prevent this, it might be helpful to add a warning or something along the lines (or let the noobs be noobs ;)).

Thanks again!

AEgit commented Apr 5, 2017

@Siedlerchr : Thank you very much! I can confirm that this feature works in the posted build!

And immediately a warning or potential improvement due to (my) typical noob behaviour. I went for "Export" instead of "Export selected". This lead to JabRef copying over all linked files (in my case ~100 GB) - even when you stop JabRef, it will continue copying over those files. Only by killing the relevant process I was able to stop the copy process.
To prevent this, it might be helpful to add a warning or something along the lines (or let the noobs be noobs ;)).

Thanks again!

@Siedlerchr

This comment has been minimized.

Show comment
Hide comment
@Siedlerchr

Siedlerchr Apr 5, 2017

Contributor

Thanks for reporting. I will try to see if I can add a break to stop the process.

Contributor

Siedlerchr commented Apr 5, 2017

Thanks for reporting. I will try to see if I can add a break to stop the process.

@Siedlerchr Siedlerchr referenced this issue Oct 30, 2017

Merged

Export pdf/linked files #3147

4 of 6 tasks complete
@Siedlerchr

This comment has been minimized.

Show comment
Hide comment
@Siedlerchr

Siedlerchr Oct 30, 2017

Contributor

@Vaver @AEgit I recently finished an improved functionality of this feature. Could you please test and give feedback on it?
http://builds.jabref.org/exportPdf/

Contributor

Siedlerchr commented Oct 30, 2017

@Vaver @AEgit I recently finished an improved functionality of this feature. Could you please test and give feedback on it?
http://builds.jabref.org/exportPdf/

@AEgit

This comment has been minimized.

Show comment
Hide comment
@AEgit

AEgit Oct 31, 2017

JabRef 4.1-dev--snapshot--2017-10-26--exportPdf--88faa7ce3
Windows 10 10.0 amd64
Java 1.8.0_151

@Siedlerchr This looks really good! Thank you very much!

I think the only thing that could be improved is the visual feedback during the copying process. Currently, if files of many entries are copied over to another folder, JabRef does not show, how long it will take to copy all the files. As far as I can tell, it is therefore currently also not possible to stop the copying process at a certain point in time, unless the relevant process is killed (copying over the files will continue even when JabRef is stopped - see #2539 (comment)).

But overall this is a massive improvement - I especially like the final table showing the results of the copying process including the full path. I also appreciated that files are not overwritten, when found in the same folder - you could add the possibility to ask the user whether she/he wants to overwrite preexisting files, but I don't think this is a big issue at all. After all, this can be sorted out before starting the copying process by the user with the folder manager of choice.

AEgit commented Oct 31, 2017

JabRef 4.1-dev--snapshot--2017-10-26--exportPdf--88faa7ce3
Windows 10 10.0 amd64
Java 1.8.0_151

@Siedlerchr This looks really good! Thank you very much!

I think the only thing that could be improved is the visual feedback during the copying process. Currently, if files of many entries are copied over to another folder, JabRef does not show, how long it will take to copy all the files. As far as I can tell, it is therefore currently also not possible to stop the copying process at a certain point in time, unless the relevant process is killed (copying over the files will continue even when JabRef is stopped - see #2539 (comment)).

But overall this is a massive improvement - I especially like the final table showing the results of the copying process including the full path. I also appreciated that files are not overwritten, when found in the same folder - you could add the possibility to ask the user whether she/he wants to overwrite preexisting files, but I don't think this is a big issue at all. After all, this can be sorted out before starting the copying process by the user with the folder manager of choice.

@Siedlerchr

This comment has been minimized.

Show comment
Hide comment
@Siedlerchr

Siedlerchr Oct 31, 2017

Contributor

Thank you very much for your feedback, regarding Cancel, have you tried clicking cancel on the progress dialog? It should cancel the whole copying process. Regarding the duration, I will see if there is a way to calculate time

Contributor

Siedlerchr commented Oct 31, 2017

Thank you very much for your feedback, regarding Cancel, have you tried clicking cancel on the progress dialog? It should cancel the whole copying process. Regarding the duration, I will see if there is a way to calculate time

@AEgit

This comment has been minimized.

Show comment
Hide comment
@AEgit

AEgit Oct 31, 2017

Hmmm I didn't see any progress dialog, to be honest - if there's one, that would probably solve all my issues.

EDIT: I've checked it again, just to be sure. I definitely cannot see any progress dialog - I only see the final results table.

AEgit commented Oct 31, 2017

Hmmm I didn't see any progress dialog, to be honest - if there's one, that would probably solve all my issues.

EDIT: I've checked it again, just to be sure. I definitely cannot see any progress dialog - I only see the final results table.

@Siedlerchr

This comment has been minimized.

Show comment
Hide comment
@Siedlerchr

Siedlerchr Oct 31, 2017

Contributor

@AEgit I noticed that the progess dialog was not shown during progress due to the execution order, Changed that now. You can try it out in a couple of minutes, if the tests succed #3147

Contributor

Siedlerchr commented Oct 31, 2017

@AEgit I noticed that the progess dialog was not shown during progress due to the execution order, Changed that now. You can try it out in a couple of minutes, if the tests succed #3147

@AEgit

This comment has been minimized.

Show comment
Hide comment
@AEgit

AEgit Oct 31, 2017

Ok, I'll do that once the updated build is available.

AEgit commented Oct 31, 2017

Ok, I'll do that once the updated build is available.

@lenhard lenhard closed this in #3147 Nov 1, 2017

@AEgit

This comment has been minimized.

Show comment
Hide comment
@AEgit

AEgit Nov 1, 2017

Is this fix already part of the master?
Because with this version the PDF copying does not work anymore: only some, but not all of the selected items are copied and no final results table is shown.

JabRef 4.1-dev--snapshot--2017-11-01--master--d5f0b695f
Windows 10 10.0 amd64
Java 1.8.0_151

AEgit commented Nov 1, 2017

Is this fix already part of the master?
Because with this version the PDF copying does not work anymore: only some, but not all of the selected items are copied and no final results table is shown.

JabRef 4.1-dev--snapshot--2017-11-01--master--d5f0b695f
Windows 10 10.0 amd64
Java 1.8.0_151

@Siedlerchr Siedlerchr reopened this Nov 1, 2017

@Siedlerchr

This comment has been minimized.

Show comment
Hide comment
@Siedlerchr

Siedlerchr Nov 1, 2017

Contributor

Ah shit I now got it, too. I will fix it asap

Contributor

Siedlerchr commented Nov 1, 2017

Ah shit I now got it, too. I will fix it asap

@Siedlerchr

This comment has been minimized.

Show comment
Hide comment
@Siedlerchr

Siedlerchr Nov 1, 2017

Contributor

Okay, I found the issue. Now both Progessdialog + result table are shown: ac723bf
Regarding the copying: I did not change any of that. It iterates over all selected entires and gets the files for each entry

Contributor

Siedlerchr commented Nov 1, 2017

Okay, I found the issue. Now both Progessdialog + result table are shown: ac723bf
Regarding the copying: I did not change any of that. It iterates over all selected entires and gets the files for each entry

@Siedlerchr Siedlerchr closed this Nov 1, 2017

@AEgit

This comment has been minimized.

Show comment
Hide comment
@AEgit

AEgit Nov 1, 2017

JabRef 4.1-dev--snapshot--2017-11-01--master--ac723bf6d
Windows 10 10.0 amd64
Java 1.8.0_151

Ok, progress dialog and result table work now.
Regarding the copying: I'll see whether I can reproduce this behaviour (so far it has happened 2 times, but afterwards things worked flawlessly).

The "Cancel" button on the progress button seems to have no effect - JabRef continues copying over files (only the progress bar is no longer shown).

AEgit commented Nov 1, 2017

JabRef 4.1-dev--snapshot--2017-11-01--master--ac723bf6d
Windows 10 10.0 amd64
Java 1.8.0_151

Ok, progress dialog and result table work now.
Regarding the copying: I'll see whether I can reproduce this behaviour (so far it has happened 2 times, but afterwards things worked flawlessly).

The "Cancel" button on the progress button seems to have no effect - JabRef continues copying over files (only the progress bar is no longer shown).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment