New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates of fields corrupt Entry Editor display #3046

Closed
wujastyk opened this Issue Jul 24, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@wujastyk

wujastyk commented Jul 24, 2017

data in a shorthand field gets displayed in a keywords field.

JabRef version

JabRef 4.0-dev--snapshot--2017-07-19--master--2f12fecfb
Linux 4.8.0-58-generic amd64
Java 1.8.0_131

Steps to reproduce:

  1. In biblatex source tab, enter:
@Book{pys,
  title     = {Pātañjalayogaśāstra},
  shorthand = {PYŚ},
}
  1. switch to the Optional fields tab

  2. looks like the attached image.

It's a bit odd too, because the field data area for "shorthand" doesn't display.

screenshot from 2017-07-24 17-20-55

@lenhard

This comment has been minimized.

Show comment
Hide comment
@lenhard

lenhard Jul 24, 2017

Member

I cannot reproduce this on Win7 with current master. Could this be related in some way to a custom field configuration? When I add a @Book entry in biblatex mode, then the "Keywords" field is displayed in the General tab and not in the Optional fields tab. Moreover, I have no Shorthand field anywhere in the entry editor.

Member

lenhard commented Jul 24, 2017

I cannot reproduce this on Win7 with current master. Could this be related in some way to a custom field configuration? When I add a @Book entry in biblatex mode, then the "Keywords" field is displayed in the General tab and not in the Optional fields tab. Moreover, I have no Shorthand field anywhere in the entry editor.

@wujastyk

This comment has been minimized.

Show comment
Hide comment
@wujastyk

wujastyk Jul 24, 2017

Yes, I had diddled with "Customize the entry types." And by mistake, I had "pubstate" twice in the Book entry type (as is seen in my screenshot above). When I deleted the extra "pubstate", the display looks correct, and the shorthand displays correctly in the Shorthand field.

So, it's a recondite buglet. If you have a field twice in your data entry tab, then you may see artefacts.

Thanks,
Dominik

JabRef 4.0-dev--snapshot--2017-07-19--master--2f12fecfb
Linux 4.8.0-58-generic amd64
Java 1.8.0_131

screenshot from 2017-07-24 20-50-06

wujastyk commented Jul 24, 2017

Yes, I had diddled with "Customize the entry types." And by mistake, I had "pubstate" twice in the Book entry type (as is seen in my screenshot above). When I deleted the extra "pubstate", the display looks correct, and the shorthand displays correctly in the Shorthand field.

So, it's a recondite buglet. If you have a field twice in your data entry tab, then you may see artefacts.

Thanks,
Dominik

JabRef 4.0-dev--snapshot--2017-07-19--master--2f12fecfb
Linux 4.8.0-58-generic amd64
Java 1.8.0_131

screenshot from 2017-07-24 20-50-06

@matthiasgeiger

This comment has been minimized.

Show comment
Hide comment
@matthiasgeiger

matthiasgeiger Jul 25, 2017

Member

Thanks for the update!
As you noted this is only a minor aspect which will not affect many users - thus, I don't add it to the 4.0 milestone.

Member

matthiasgeiger commented Jul 25, 2017

Thanks for the update!
As you noted this is only a minor aspect which will not affect many users - thus, I don't add it to the 4.0 milestone.

@matthiasgeiger matthiasgeiger changed the title from Shorthand field not filling correctly to Duplicates of fields corrupt Entry Editor display Jul 25, 2017

tobiasdiez added a commit that referenced this issue Nov 5, 2017

tobiasdiez added a commit that referenced this issue Nov 6, 2017

Fix #3046: No longer allow duplicate fields in customized entry types (
…#3405)

* Fix #3046: No longer allow duplicate fields in customized entry types

* Fix tests

* Fix tests 2

Siedlerchr added a commit that referenced this issue Nov 10, 2017

Merge remote-tracking branch 'upstream/master' into sharelatex
* upstream/master: (26 commits)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  Strip invalid prolog when loading CitationStyles (#3404)
  Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362)
  Update gradle from 4.2.1 to 4.3
  Update gradle from 4.2.1 to 4.3
  ...

Siedlerchr added a commit that referenced this issue Nov 18, 2017

Merge remote-tracking branch 'upstream/master' into linuxlink
* upstream/master: (23 commits)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  Strip invalid prolog when loading CitationStyles (#3404)
  Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362)
  Update gradle from 4.2.1 to 4.3
  ...

Siedlerchr added a commit that referenced this issue Nov 19, 2017

Merge remote-tracking branch 'upstream/master' into selectFilesDlg
* upstream/master: (30 commits)
  Add Hint for checking master version (#3439)
  Replace LinkedFiles backslashes with forward slashes (#3403)
  fix isbn result from chimbori (#3442)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment