New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation messages are displayed at wrong position #3145

Closed
tobiasdiez opened this Issue Aug 22, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@tobiasdiez
Member

tobiasdiez commented Aug 22, 2017

Latest master. The validation messages in the entry editor are shifted to the bottom (by what appears to be a fixed constant):
image

@tobiasdiez tobiasdiez added the bug label Aug 22, 2017

@tobiasdiez tobiasdiez added this to the v4.0 milestone Aug 22, 2017

@lenhard

This comment has been minimized.

Member

lenhard commented Aug 22, 2017

Confirmed, but it's not only that.

For me, DOI and URL warnings in the general fields tab are shifted upwards by a threshold.

I just reset my master branch to the beta3 and it was already broken there. Now I wonder, did the feature ever work? Were there library updates that broke this? We surely didn't change the code.

@tobiasdiez

This comment has been minimized.

Member

tobiasdiez commented Aug 23, 2017

No it never worked as desired (I just tested it with my original branch). I filed a bug report at controlsfx.

EDIT: there are currently 2 PRs in the pipeline that attempt to fix this issue 682. Once they are merged, the new snapshot is available here: https://oss.sonatype.org/content/repositories/snapshots/org/controlsfx/controlsfx/8.40.15-SNAPSHOT/

@lenhard

This comment has been minimized.

Member

lenhard commented Aug 23, 2017

Damn :-( How did we not see that? I was very convinced that I saw it working.

What does that mean for 4.0? I would suggest that we add a preference option for enabling/disabling validation that is initially set to disabled. When the feature works properly, we can add the UI part to that allows you to enable the preference. That way, we keep the code, but do not annoy users.

@matthiasgeiger

This comment has been minimized.

Member

matthiasgeiger commented Aug 23, 2017

Strangely if I click into an "invalid" editor field the sign is then positioned at the right position... and yes: I first noticed this in the branch of @lenhard's resizing - and I was pretty sure that I have never seen it displayed in that wrong way before... 😕

@koppor koppor added the entry-editor label Aug 25, 2017

@koppor

This comment has been minimized.

Member

koppor commented Aug 25, 2017

@matthiasgeiger I would assume that with the CSS patch by @lenhard leads to the initial size not being 0 and thus the issue https://bitbucket.org/controlsfx/controlsfx/issues/791/update-position-of-decoration-when-target is risen:

The problem is that size listener is only registered if the initial size was 0

Please sign it at bitbucket and cast a vote for the issue. Maybe that helps to get the CustomFX library fixed.

@lenhard

This comment has been minimized.

Member

lenhard commented Aug 25, 2017

@koppor My CSS patch is not the cause. We are talking about the master branch here and my patch is still an unmerged PR.

@lenhard

This comment has been minimized.

Member

lenhard commented Aug 27, 2017

The validation feature is now masked by a preference option. It will be re-enabled once the bug is fixed in controlsfx. Hence this can be removed from the 4.0 milestone and I'll re-categorize it from bug to feature.

@lenhard lenhard removed this from the v4.0 milestone Aug 27, 2017

@lenhard lenhard added feature and removed bug labels Aug 27, 2017

tobiasdiez added a commit that referenced this issue Jan 12, 2018

Merge pull request #3610 from JabRef/reactivateValidation
Implements #3145: Show validation messages in entry editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment