Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of files should keep file in directory #3619

Closed
koppor opened this issue Jan 8, 2018 · 6 comments
Closed

Renaming of files should keep file in directory #3619

koppor opened this issue Jan 8, 2018 · 6 comments

Comments

@koppor
Copy link
Member

@koppor koppor commented Jan 8, 2018

This is a regression of 3.x to 4.1. I'm not sure which version it worked at last.

Steps to reproduce:

  1. Store a file in bibdir/subdir
  2. Execute cleanup

grafik

  1. File is renamend AND MOVED to bibdir

Expected: File should be put into bibdir/subdir.

@Siedlerchr
Copy link
Contributor

@Siedlerchr Siedlerchr commented Jan 8, 2018

From your screenshot it appears that you have both renaming and moving enabled
"Move linked files to default file directory" -> BtSync\lit...

@koppor
Copy link
Member Author

@koppor koppor commented Jan 8, 2018

Then, the default should be disabled. Or be more intelligent? The button should not be checked if the file is already in a subdirectory of the bib dir?

@tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Jan 8, 2018

Didn't we introduce the file directory pattern to handle the placement in subdirectories? Maybe I just don't see your usecase but I would like to keep the algorithm as simple as possible.

@koppor
Copy link
Member Author

@koppor koppor commented Jan 9, 2018

Sometimes, I am the only user of JabRef using the advanced features. I should begin writing blog entries. 😇

I manually place files in the (for me) correct file folder. Then, I drop them into the main table/entry editor to get them linked (refs #121). The dialog is currently not appearing as in version 3.x, so I push the cleanup button and expect that JabRef just renames the file. For me, removing a checkmark to keep a file in the current directory (which was hard work to choose ;)), is counter-intuitive for me.

@tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Jan 9, 2018

Ok, I see your point. But how should JabRef detect that you placed the file in the correct directory?

@koppor
Copy link
Member Author

@koppor koppor commented Jan 9, 2018

If it is in a sub directory of the default directory, it is correct. The check is the same as used for "Rename only PDFs having a relative path".

I am not sure whether the least WTF would be to set the default of "Move linked files to the default folder ..." to false. Not any check. --> implemented in #3620.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.