Delete from disk should not be default option/selected on DELETE in file tab #3679
Labels
Comments
Hi! I have submitted a pull request (#3690) aiming to fix this issue (and another issue with the "Cancel" button, which I discovered during testing my first change). I would appreciate it if you could review the changes and suggest possible improvements! |
tobiasdiez
added a commit
that referenced
this issue
Feb 5, 2018
* Only remove file links from entries by default (#3679) When a file link in a bibliography entry is deleted by the user, a dialog is displayed. Previously, the default (first) dialog option deleted the linked file from disk. This commit changes the default behaviour to just removing the file link from the entry. * Fix canceling bug in file link deletion dialog When clicking "Cancel" button in the file link deletion dialog, the file link was being deleted from the list. This commit fixes this behaviour by changing the return value of the delete() method when the "Cancel" button is chosen. * Tag link removal button as default (#3679) The "remove from entry" option in the file link removal dialog window has been tagged with the ButtonData.YES type to ensure correct positioning and behaviour on all platforms. * Add test cases for linked file removal dialog * Code style adjustments in dialog test cases * Added non-empty link to file in one test for clarity * Removed unnecessary newlines * Changed test method names to adhere to chosen naming convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Changing the buttons should be sufficient.
The text was updated successfully, but these errors were encountered: