/jabref

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete from disk should not be default option/selected on DELETE in file tab #3679

Closed
stefan-kolb opened this Issue Jan 31, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@stefan-kolb @bdach @Siedlerchr
@stefan-kolb
Member

stefan-kolb commented Jan 31, 2018

image

Changing the buttons should be sufficient.

@stefan-kolb stefan-kolb added enhancement ui labels Jan 31, 2018

@Siedlerchr Siedlerchr added the good first issue label Feb 3, 2018

bdach added a commit to bdach/jabref that referenced this issue Feb 3, 2018

@bdach
Only remove file links from entries by default (JabRef#3679) 
When a file link in a bibliography entry is deleted by the user,
a dialog is displayed. Previously, the default (first) dialog option
deleted the linked file from disk. This commit changes the default
behaviour to just removing the file link from the entry.
4c9af77

@bdach bdach referenced this issue Feb 3, 2018

Merged

[WIP] File link deletion dialog improvements #3690

4 of 5 tasks complete
@bdach

This comment has been minimized.

Sign in to view
Contributor

bdach commented Feb 3, 2018 •
edited

Hi! 👋

I have submitted a pull request (#3690) aiming to fix this issue (and another issue with the "Cancel" button, which I discovered during testing my first change). I would appreciate it if you could review the changes and suggest possible improvements!

bdach added a commit to bdach/jabref that referenced this issue Feb 4, 2018

@bdach
Tag link removal button as default (JabRef#3679) 
The "remove from entry" option in the file link removal dialog window
has been tagged with the ButtonData.YES type to ensure correct
positioning and behaviour on all platforms.
467b70a

@tobiasdiez tobiasdiez closed this in #3690 Feb 5, 2018

tobiasdiez added a commit that referenced this issue Feb 5, 2018

@bdach @tobiasdiez
[WIP] File link deletion dialog improvements (#3690) 
* Only remove file links from entries by default (#3679)

When a file link in a bibliography entry is deleted by the user,
a dialog is displayed. Previously, the default (first) dialog option
deleted the linked file from disk. This commit changes the default
behaviour to just removing the file link from the entry.

* Fix canceling bug in file link deletion dialog

When clicking "Cancel" button in the file link deletion dialog, the file
link was being deleted from the list. This commit fixes this behaviour
by changing the return value of the delete() method when the "Cancel"
button is chosen.

* Tag link removal button as default (#3679)

The "remove from entry" option in the file link removal dialog window
has been tagged with the ButtonData.YES type to ensure correct
positioning and behaviour on all platforms.

* Add test cases for linked file removal dialog

* Code style adjustments in dialog test cases

* Added non-empty link to file in one test for clarity
* Removed unnecessary newlines
* Changed test method names to adhere to chosen naming convention
Loading status checks…
b960da1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment