Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a file link at General when editing an entry can lead to errnoneous double removal #3926

Closed
Sethur opened this issue Apr 4, 2018 · 3 comments

Comments

@Sethur
Copy link

@Sethur Sethur commented Apr 4, 2018

Tested in latest master dev and persisting.

JabRef version 4.1 on Windows 7 with Java x64 version 8 update 162

Steps to reproduce:

  1. Attach two files to an entry, rename the first so that it points to a non-existing file
  2. Go to the General tab, mark the non-existing entry in the File box, press DEL
  3. The non-existant link will instantly disappear and the next file entry will be selected, nevertheless a dialog will pop up asking for a "delete link only" vs. "also delete file" selection
  4. Click Remove from Entry
  5. Watch your good link disappear as well
  6. Profit

image

@Sethur
Copy link
Author

@Sethur Sethur commented Apr 4, 2018

Update: The screenshot is from an example where both files are valid, I think you explicitely need a non-existant file to reproduce this. There seems to be a check if the file exists. If not, it is instantly removed without waiting for the dialog input. Then, when you click Remove from entry, the next file will be removed as well since it is already auto-selected. Clicking Cancel at this point will circumvent the issue, but this is less than ideal.

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Apr 4, 2018

Ah yes, I can confirm this behaviour. I have an entry with an url as file link and a pdf. that is really odd. I#ll take a look at this

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Apr 4, 2018

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master (in a couple of minutes) and report back if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants