Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search not available #4096

Closed
koppor opened this issue Jun 5, 2018 · 20 comments · Fixed by #8045
Closed

Global search not available #4096

koppor opened this issue Jun 5, 2018 · 20 comments · Fixed by #8045

Comments

@koppor
Copy link
Member

koppor commented Jun 5, 2018

Currently that the content of the search field is bound to a tab. In the old versions, it was globally stored. So I could click through the tabs and see if an entry is available somewhere.

search

Refs #1549, #104 (comment), #332, #1981

This is the thing, I miss most. I think, we described all our search features at https://help.jabref.org/en/Search for a description of our search capabilities. I can agree to go through the documentation and redesign it.

@tobiasdiez
Copy link
Member

tobiasdiez commented Jun 5, 2018

I think one can make an argument for both behaviors. @JabRef/developers opinions?

@tobiasdiez tobiasdiez added this to To Do (nice to have) in Maintable in JavaFX via automation Jun 5, 2018
@LinusDietz
Copy link
Member

LinusDietz commented Jun 5, 2018

I think it should be global. Also, there should be an indication in the tab whether there are results in the respective bibliographies.

@stefan-kolb
Copy link
Member

stefan-kolb commented Jun 5, 2018

One could implement it like that, but I guess this comes with a performance penalty, especially if we also check the other tabs without focus.

@tobiasdiez tobiasdiez moved this from To Do (nice to have) to To Do in Maintable in JavaFX Jun 5, 2018
@LinusDietz
Copy link
Member

LinusDietz commented Jun 6, 2018

Well, I think the performance overhead is not really too bad, since it is a linear increase with the number of bibliographies.

@stefan-kolb
Copy link
Member

stefan-kolb commented Jun 6, 2018

I guess the performance is already bad in a single database with a lot of entries. At least if I recall the reports correctly.

@tobiasdiez tobiasdiez added this to ToDo in JavaFX UI Rework via automation Jun 17, 2018
@teertinker
Copy link
Contributor

teertinker commented Jan 19, 2020

For me, removing all sorts of global search in the current 5.0(beta1) is really a drawback. I always work with several tabs - and I think JabRef is intended to be used that way. When I search for an entry, I now have to enter the search term several times. Especially when using complex search terms, this becomes very time consuming. I really liked the additional global search window. Wouldn't it at least be possible to give an option to keep the search-term when switching tabs?

@acfrery
Copy link

acfrery commented Jan 20, 2020

The global search option is fundamental.

@ytzemih
Copy link

ytzemih commented Mar 2, 2020

I am with @tobiasdiez that both options are useful. However, I in my context, I have used (and would desire to use) global search by far most often (afaik in JR3, both options were available, the search interface was actually quite fast and flexible). Moreover, tab-specific search has proven to be very inconvenient to me as I am usually working with 4-6 medium to large bib files, sometimes up to 10 depending on the projects I am involved. In at least 95% of the cases, I want to have the same search repeated/updated whenever I change the tab. One could say this is not how JR should be used in which case I am happy to receive some suggestions. On this note, it'd be nice to have a search history in the search field to assist in autocompletion. That might be an alternative to tab-specific search. So, like @teertinker and others, I am experiencing the search as it is now as a clear drawback, particularly, in combination with JR5 search's significantly lower time performance than the JR4 search. Thanks a lot.

@teertinker
Copy link
Contributor

teertinker commented Mar 15, 2020

Can any development about the issue be expected in a foreseeable future? Is this about technical problems or design decisions? Honestly, I don't understand why global search has been removed. If working with tabs is a feature of jabref (which it really is - compared to other software like endnote), then workflows between tabs should be designed to be seamless. If a background search of all databases is too heavy, solutions in between are appreciated.

@stefan-kolb
Copy link
Member

stefan-kolb commented Mar 15, 2020

It is more or less a resource issue. The scarce resource is the unpaid developer that needs to implement this.

@koppor koppor added this to Normal priority in Features & Enhancements via automation Apr 3, 2020
@koppor koppor moved this from Normal priority to Low priority in Features & Enhancements Apr 3, 2020
@koppor koppor added this to Medium in Candidates for university projects via automation Sep 1, 2020
@koppor koppor moved this from Medium to Big in Candidates for university projects Sep 1, 2020
@koppor
Copy link
Member Author

koppor commented Sep 1, 2020

For the student project: Implement the search popup, where the ALL opened libraries are searched for papers. Start an old JabRef version (3.8.1 or so) using JRE8 to see the functionality.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2021

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@ytzemih
Copy link

ytzemih commented Mar 1, 2021

From personal experience, the other posts here, and from other applications with similar functionality, I believe global search as described above is generally a relevant feature. E.g., I'd need to use it most of the time when I search in JR. JR 2 and 3 had this feature, as far as I remember, but it seems from the discussion that it's difficult to implement in JR 5. What is the technical reason for this difficulty?
I imagine very naivly that if a "global search switch" is true then the search is refreshed whenever the active file tab is changed, an event that I believe could be associated with a corresponding "refreshSearch" handler. That doesn't sound to be difficult to implement but it's probably not the most elegant way to do it. Thanks for any comments.

@teertinker
Copy link
Contributor

teertinker commented Mar 18, 2021

Irrespective of the missing ability to search across different tabs, I just discovered that the search function works different than the group search function (which works across tabs). This seems to be illogical for me as a user.

Just compare the two screenshots. The search term "Wo" in the group filter is remembered when switching tabs.
grafik

grafik

I'd wish the same behavior for the general search field.

@kainagel
Copy link

kainagel commented May 2, 2021

Before you close this issue because of inactivity: Global search was the feature I used most in jabref. Now I need to go manually through all tabs ... :-(

@koppor koppor moved this from Low priority to High priority in Features & Enhancements May 3, 2021
@koppor koppor moved this from Big to Medium in Candidates for university projects Jul 5, 2021
@koppor
Copy link
Member Author

koppor commented Jul 5, 2021

This issue also includes to have a global search window showing the search results for all opened databases. One can see this in JabRef 3.8.2.

@koppor
Copy link
Member Author

koppor commented Aug 2, 2021

In JabRef 4.3.1, it was toggle button

grafik

Keep Search String throughout all opened tabs

JabRef main (as of today)

grafik

grafik

Toggle Button On

grafik

grafik

Toggle Button Off

grafik

grafik

Global Search Dialog

This dialog searches all opened databases and is called by a special button

grafik

grafik

@ytzemih
Copy link

ytzemih commented Aug 3, 2021

Thanks for this summary. It's a pity to see that this clean search concept (which is a faithful extension of what is there now) got lost over the years. I wonder what the reason was.

@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 3, 2021

It got lost by the transformation of the old GUI to the new GUI technology, but we are planning to reimplement this

@ytzemih
Copy link

ytzemih commented Aug 3, 2021

I see, that makes sense. Thanks for letting me know.

@Siedlerchr Siedlerchr self-assigned this Aug 28, 2021
@Siedlerchr Siedlerchr mentioned this issue Aug 31, 2021
7 tasks
Features & Enhancements automation moved this from High priority to Done Sep 2, 2021
@calixtus calixtus added this to done (merged into master) in JabRef Maintainers' Focus Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
JabRef Maintainers' Focus
  
done (merged into master)
Development

Successfully merging a pull request may close this issue.

9 participants