From 3611dfa85e63311d15cf2ec54df83cc3dadda2e0 Mon Sep 17 00:00:00 2001 From: DumitruDruta Date: Fri, 5 Jan 2024 11:08:39 +0100 Subject: [PATCH 1/7] Changed default status of 'Automatically open folder of attached files' --- .../jabref/gui/preferences/external/ExternalTabViewModel.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java b/src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java index f8e7f96993c..03a801d5b30 100644 --- a/src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java +++ b/src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java @@ -89,7 +89,7 @@ public ExternalTabViewModel(DialogService dialogService, PreferencesService pref @Override public void setValues() { eMailReferenceSubjectProperty.setValue(initialExternalApplicationPreferences.getEmailSubject()); - autoOpenAttachedFoldersProperty.setValue(initialExternalApplicationPreferences.shouldAutoOpenEmailAttachmentsFolder()); + autoOpenAttachedFoldersProperty.setValue(!initialExternalApplicationPreferences.shouldAutoOpenEmailAttachmentsFolder()); pushToApplicationsListProperty.setValue( FXCollections.observableArrayList(PushToApplications.getAllApplications(dialogService, preferences))); From 551f6a0466f6887a093a07dc2cb991a422ec91db Mon Sep 17 00:00:00 2001 From: DumitruDruta Date: Fri, 5 Jan 2024 12:14:32 +0100 Subject: [PATCH 2/7] Changed the original default value --- .../jabref/gui/preferences/external/ExternalTabViewModel.java | 2 +- src/main/java/org/jabref/preferences/JabRefPreferences.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java b/src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java index 7f20b268ab0..365b7b694d0 100644 --- a/src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java +++ b/src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java @@ -90,7 +90,7 @@ public ExternalTabViewModel(DialogService dialogService, PreferencesService pref @Override public void setValues() { eMailReferenceSubjectProperty.setValue(initialExternalApplicationPreferences.getEmailSubject()); - autoOpenAttachedFoldersProperty.setValue(!initialExternalApplicationPreferences.shouldAutoOpenEmailAttachmentsFolder()); + autoOpenAttachedFoldersProperty.setValue(initialExternalApplicationPreferences.shouldAutoOpenEmailAttachmentsFolder()); pushToApplicationsListProperty.setValue( FXCollections.observableArrayList(PushToApplications.getAllApplications(dialogService, preferences))); diff --git a/src/main/java/org/jabref/preferences/JabRefPreferences.java b/src/main/java/org/jabref/preferences/JabRefPreferences.java index 65b320e5971..e4e6ef60fd5 100644 --- a/src/main/java/org/jabref/preferences/JabRefPreferences.java +++ b/src/main/java/org/jabref/preferences/JabRefPreferences.java @@ -737,7 +737,7 @@ private JabRefPreferences() { defaults.put(KEY_GEN_ALWAYS_ADD_LETTER, Boolean.FALSE); defaults.put(EMAIL_SUBJECT, Localization.lang("References")); defaults.put(KINDLE_EMAIL, ""); - defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.FALSE); + defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.TRUE); defaults.put(WEB_SEARCH_VISIBLE, Boolean.TRUE); defaults.put(GROUP_SIDEPANE_VISIBLE, Boolean.TRUE); defaults.put(SELECTED_FETCHER_INDEX, 0); From f0911bbca9ad27aa78b32c5fe7aed8939cfa2e32 Mon Sep 17 00:00:00 2001 From: DumitruDruta Date: Sat, 6 Jan 2024 12:31:47 +0100 Subject: [PATCH 3/7] Updated CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ede9ae9a686..4878635c414 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv ### Changed +- The "Automatically open folders of attached files" preference default status has been changed to enabled.[#56](https://github.com/koppor/jabref/issues/56) - The Custom export format now uses the custom DOI base URI in the preferences for the `DOICheck`, if activated [forum#4084](https://discourse.jabref.org/t/export-html-disregards-custom-doi-base-uri/4084) ### Fixed From bd1e9a7bb7c9461a4d3594cfed408caea12b819b Mon Sep 17 00:00:00 2001 From: Christoph Date: Sat, 6 Jan 2024 15:14:15 +0100 Subject: [PATCH 4/7] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4878635c414..434ee5bda9b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv ### Changed -- The "Automatically open folders of attached files" preference default status has been changed to enabled.[#56](https://github.com/koppor/jabref/issues/56) +- The "Automatically open folders of attached files" preference default status has been changed to enabled.[koppor#56](https://github.com/koppor/jabref/issues/56) - The Custom export format now uses the custom DOI base URI in the preferences for the `DOICheck`, if activated [forum#4084](https://discourse.jabref.org/t/export-html-disregards-custom-doi-base-uri/4084) ### Fixed From 41cbd863313563caf5311ccbb94309a6b32a8bdc Mon Sep 17 00:00:00 2001 From: DumitruDruta Date: Tue, 9 Jan 2024 09:44:18 +0100 Subject: [PATCH 5/7] Made changes OS specific --- CHANGELOG.md | 2 +- .../java/org/jabref/preferences/JabRefPreferences.java | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bab57b715a7..c17b273d678 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv ### Changed -- The "Automatically open folders of attached files" preference default status has been changed to enabled.[koppor#56](https://github.com/koppor/jabref/issues/56) +- The "Automatically open folders of attached files" preference default status has been changed to enabled on Windows.[koppor#56](https://github.com/koppor/jabref/issues/56) - The Custom export format now uses the custom DOI base URI in the preferences for the `DOICheck`, if activated [forum#4084](https://discourse.jabref.org/t/export-html-disregards-custom-doi-base-uri/4084) - The index directories for full text search have now more readable names to increase debugging possibilities using Apache Lucense's Lurk. [#10193](https://github.com/JabRef/jabref/issues/10193) - The fulltext search also indexes files ending with .pdf (but do not having an explicit file type set). [#10193](https://github.com/JabRef/jabref/issues/10193) diff --git a/src/main/java/org/jabref/preferences/JabRefPreferences.java b/src/main/java/org/jabref/preferences/JabRefPreferences.java index e4e6ef60fd5..cf0f1fcafd5 100644 --- a/src/main/java/org/jabref/preferences/JabRefPreferences.java +++ b/src/main/java/org/jabref/preferences/JabRefPreferences.java @@ -737,7 +737,13 @@ private JabRefPreferences() { defaults.put(KEY_GEN_ALWAYS_ADD_LETTER, Boolean.FALSE); defaults.put(EMAIL_SUBJECT, Localization.lang("References")); defaults.put(KINDLE_EMAIL, ""); - defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.TRUE); + + if (OS.WINDOWS){ + defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.TRUE); + }else { + defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.FALSE); + } + defaults.put(WEB_SEARCH_VISIBLE, Boolean.TRUE); defaults.put(GROUP_SIDEPANE_VISIBLE, Boolean.TRUE); defaults.put(SELECTED_FETCHER_INDEX, 0); From 2f15bbcd6651e3e4204293989510bcca4b6d2eac Mon Sep 17 00:00:00 2001 From: DumitruDruta Date: Tue, 9 Jan 2024 09:58:12 +0100 Subject: [PATCH 6/7] Whitespace issues fixed --- src/main/java/org/jabref/preferences/JabRefPreferences.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jabref/preferences/JabRefPreferences.java b/src/main/java/org/jabref/preferences/JabRefPreferences.java index cf0f1fcafd5..30670250f62 100644 --- a/src/main/java/org/jabref/preferences/JabRefPreferences.java +++ b/src/main/java/org/jabref/preferences/JabRefPreferences.java @@ -738,9 +738,9 @@ private JabRefPreferences() { defaults.put(EMAIL_SUBJECT, Localization.lang("References")); defaults.put(KINDLE_EMAIL, ""); - if (OS.WINDOWS){ + if (OS.WINDOWS) { defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.TRUE); - }else { + } else { defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.FALSE); } From 4b3e5e00cf79237c2d01919adaa57121e8cef118 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Tue, 9 Jan 2024 11:08:41 +0100 Subject: [PATCH 7/7] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c17b273d678..744c6d801b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv ### Changed -- The "Automatically open folders of attached files" preference default status has been changed to enabled on Windows.[koppor#56](https://github.com/koppor/jabref/issues/56) +- The "Automatically open folders of attached files" preference default status has been changed to enabled on Windows. [koppor#56](https://github.com/koppor/jabref/issues/56) - The Custom export format now uses the custom DOI base URI in the preferences for the `DOICheck`, if activated [forum#4084](https://discourse.jabref.org/t/export-html-disregards-custom-doi-base-uri/4084) - The index directories for full text search have now more readable names to increase debugging possibilities using Apache Lucense's Lurk. [#10193](https://github.com/JabRef/jabref/issues/10193) - The fulltext search also indexes files ending with .pdf (but do not having an explicit file type set). [#10193](https://github.com/JabRef/jabref/issues/10193)