Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added change listener for crossref field #1645
Another WIP just to show what is coming (as I may be unavailable for a week or so now).
Change listener that updates the crossref field when the key changes. In the longer run this will be extended to all field with keys, see #1637.
Will continue with tests and CHANGELOG entries eventually.
Potential issue: when deleting an entry all references to it in
Not sure what the best solution is. Either not removing the keys in the fields, leading to an inconsistent database, or keeping it as it is, that the information is lost. I cannot really see how to actually undo it. It is of course possible to add undo information from the listener, but then it will be a separate undo compound compared to the remove, so one will need to undo twice...
Apart from that, this PR should be ready for review.
I changed so that each BibDatabase creates and adds a KeyChangeListener, so it will always be present. I must have downloaded some updates on my mobile broadband, so I have very limited data left for the rest of the month. Hence, all updates will come Thursday evening (when I'm back with WiFi).
Aug 12, 2016
This was referenced
Aug 16, 2016
added a commit
this pull request
Sep 5, 2016
This is dangerious.
Unless you can implement it like the BibDesk, I think it is better to put this feature into the Cleanup tools. The user can call for it only when she wants to update changes. It is dangerous otherwise. I was shocked when I see all of them have lost their link. if not for Timemachine, I would be crying by now.