Rewrite bibtexml importer with JAXB parser #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bibEntry.setType("unpublished"); | ||
| parseUnpublished(entry.getUnpublished(), fields); | ||
| } | ||
| if (entry.getId() != null) { |
There was a problem hiding this comment.
This if condition shouldn't be necessary as the xsd schema file specifies the attribute as use="required"
boceckts
changed the title
| if (method.getName().equals("getNumber")) { | ||
| putNumber(fields, (BigInteger) method.invoke(t)); | ||
| continue; | ||
| } |
tschechlovdev
force-pushed
the
bibtexml-importer
branch
from
6991e26
to
025ee20
Compare
| * "abstract" will be put as key to fields and the value of <Code>getAbstract</Code> will be put as value to fields. | ||
| * Some <Code>get</Code> methods shouldn't be mapped to fields, so <Code>getClass</Code> for example will be skipped. | ||
| * | ||
| * @param t |
There was a problem hiding this comment.
Either write a parameter description or leave the tag out.
There was a problem hiding this comment.
Also rename, maybe entryType is fitting?
There was a problem hiding this comment.
I renamed it to entryType and added a description.
boceckts
added
status: ready-for-review
tschechlovdev
force-pushed
the
bibtexml-importer
branch
from
f0cc410
to
fe63c1a
Compare
tschechlovdev
changed the title
| } | ||
| return new ParserResult(bibItems); | ||
| } | ||
|
|
||
| /** | ||
| * In this method, all <Code>get</Code> methods that t has will be used and their value will be put to fields, |
koppor
removed
the
status: ready-for-review
tschechlovdev
added
the
status: ready-for-review
|
Are there any other remarks? |
| } catch (javax.xml.parsers.ParserConfigurationException e) { | ||
| JAXBContext context = JAXBContext.newInstance("net.sf.jabref.importer.fileformat.bibtexml"); | ||
| XMLInputFactory xmlInputFactory = XMLInputFactory.newFactory(); | ||
| XMLStreamReader xmlReader = xmlInputFactory.createXMLStreamReader(reader); |
There was a problem hiding this comment.
Why can't directly the reader used as input for the unmarshaller?
The JavaDocs of the unmarshaller say so: https://jaxb.java.net/nonav/2.2.4/docs/api/javax/xml/bind/Unmarshaller.html
Reading that, the code would be much shorter and especially lines 106 to 109 would be obsolete
There was a problem hiding this comment.
Done. I've used directly the reader as input.
# Conflicts: # src/main/java/net/sf/jabref/logic/importer/fileformat/BibTeXMLImporter.java # src/test/java/net/sf/jabref/logic/importer/fileformat/BibTeXMLImporterTest.java
koppor
removed
the
status: ready-for-review
|
Travis is failing because of UI tests... |
tschechlovdev
added
the
status: ready-for-review
|
Please not that the UI tests are done but ignored. Please read the travis output and check for red lines Checkstyle failed. Your IDE settings seem to be non-formant. Please double check: https://github.com/JabRef/jabref/wiki/Guidelines-for-setting-up-a-local-workspace#intellij |
Closed
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Aug 18, 2016
* master: Fix imports Rename NewFileDialog -> FileDialog Also cancel duplicate finder workflow on close button Removed/moved preferences which are constants implements JabRef#1767: Add Help Button to access new help page Fixed BibTeXMLImporter Set more default file filters in dialogs JabRef#1763 Resolve crossrefs and strings in main table (JabRef#1644) Rewrite bibtexml importer with JAXB parser (JabRef#1666) Moved a few more initialization to GUIGlobals.init() (JabRef#1756) Added program to generate a table of all characters and fixed some characters (JabRef#1766) Improve focus of the maintable after a sidepane gets closed (JabRef#1741) Table row height adjusts on Windows as the font scales with the menu (JabRef#1623) Added more characters to converters (JabRef#1761)
ayanai1
pushed a commit
to ayanai1/jabref
that referenced
this pull request
Sep 5, 2016
* rewrite bibtexml importer with jaxb parser * address comments * remove unused import * include feedback * fix import order, log and add testfile
koppor
removed
the
status: ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding: #898
I've rewritten the bibtexml importer: It was written with a SAX parser and I've used a JAXB parser. I will be addings some more tests for the changes I've made.
Note: Exporting in bibtexml format and then trying to import in bibtexml format is not working because of #1665.