New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DOI importer to use application/x-bibtex #37

Merged
merged 4 commits into from Apr 9, 2015

Conversation

Projects
None yet
2 participants
@nsheff

nsheff commented Apr 7, 2015

Changes the CrossRef content negotiation method to yield more complete bibtex entries. This fixes an issue with DOI import from papers with many authors, which previously yielded truncated results.

NS
Change DOI importer to use application/x-bibtex
Changes the CrossRef content negotiation method to yield more complete bibtex entries.
@nsheff

This comment has been minimized.

Show comment
Hide comment
@nsheff

nsheff Apr 7, 2015

Please see CrossRef content negotiation documentation for information about why I propose this change

nsheff commented Apr 7, 2015

Please see CrossRef content negotiation documentation for information about why I propose this change

@koppor

This comment has been minimized.

Show comment
Hide comment
@koppor

koppor Apr 8, 2015

Member

Thank you for the update. Could you also adapt the CHANGELOG and the About.html as described at https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md?

Member

koppor commented Apr 8, 2015

Thank you for the update. Could you also adapt the CHANGELOG and the About.html as described at https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md?

@nsheff

This comment has been minimized.

Show comment
Hide comment
@nsheff

nsheff Apr 8, 2015

I can -- but it was just a single line change so I wasn't sure it was worth adding myself as a contributor, or updating the CHANGELOG. Do you still want those updates for such a simple change?

nsheff commented Apr 8, 2015

I can -- but it was just a single line change so I wasn't sure it was worth adding myself as a contributor, or updating the CHANGELOG. Do you still want those updates for such a simple change?

@koppor

This comment has been minimized.

Show comment
Hide comment
@koppor

koppor Apr 8, 2015

Member

Yeah, sure.

Member

koppor commented Apr 8, 2015

Yeah, sure.

@nsheff

This comment has been minimized.

Show comment
Hide comment
@nsheff

nsheff commented Apr 9, 2015

Done.

koppor added a commit that referenced this pull request Apr 9, 2015

Merge pull request #37 from sheffien/master
Change DOI importer to use application/x-bibtex

@koppor koppor merged commit a18d679 into JabRef:master Apr 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment