Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix for issue 3959: migrate all tests to JUnit 5 #4260
Hi, I'm trying to fix the issue #3959 , and I have some problems here. Can someone help me?
1. Some tests don't seem to have a parameter source
2. Something about the external libraries
3. The Database Test
4. The GUI Test
5. About CleanupWorkerTest
And if there are any errors or something can be improved in other tests that I didn't mention, please let me know! Thanks!
*SearchQueryHighlightObservableTest.java -did not use MockitoExtension.class as its official version has not been released yet.
*ProtectedTermsLoaderTest.java -When running tests, outputs in command line are different. I don't know if this change is correct.
That now some of the exporter tests fail, were my fear. This probably needs further investigations and fixes for the exporter; thus it goes beyond the current PR. Thus, I propose to mark the tests as ignored/disabled for now and we will come back later to fix them.
Okay, I found the issue with the paths. I really wondered if it ever worked... But well, now it does. The key is to point to one existing resource. The rest can be found dynamically.
And this leads us actually to some failing tests. But I would ignore that for the moment. That is a difference.
@Metatronwings You can use this patch as a start for all the related importer/exporter tests.
I'm very glad to see this issue will be resolved by us soon. Only a few more small questions:
1. Some tests have not been migrated yet.
2. Since I didn't migrate them, how should I write the
And thanks for all of you!
@Metatronwings It's okay, we will sure find a way for them in the long run. Not that important.
We hope you enjoyed it and if you want you can also further contribute. Looking to see more from you ;)
I just converted the two other classes with the legacy file methods to use the nio stuff.