Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

auto-hiding janrain modal on load and only displaying on ui.showLogin #438

Merged
merged 1 commit into from

4 participants

@samandmoore
Collaborator

this fixes the second part of issue #421 (the issue posted by @ntulip).

It just hides the janrain engage modal by default and only shows it when the ui triggers the login modal to be displayed.

thanks to @johnsheehan for the fix :)

@davidfowl davidfowl merged commit b00b343 into JabbR:master
@davidfowl
Owner

Test it out on staging http://jabbr-staging.apphb.com/

@johnsheehan

looks like it's working great for me

@ntulip

Works for me too. Thank you all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +2 −0  JabbR/Chat.ui.js
  2. +1 −1  JabbR/index.htm
View
2  JabbR/Chat.ui.js
@@ -1444,10 +1444,12 @@
showLogin: function () {
if (janrain.ready === false) {
window.setTimeout(function () {
+ $login.show();
janrain.engage.signin.modal.init();
}, 1000);
}
else {
+ $login.show();
janrain.engage.signin.modal.init();
}
},
View
2  JabbR/index.htm
@@ -223,7 +223,7 @@ <h3 class="userlist-header nav-header">
</li>
</ul>
</div>
- <div id="janrainEngageEmbed">
+ <div id="janrainEngageEmbed" style="display: none;">
</div>
<div id="chat-area">
<ul id="messages-lobby" class="messages current">
Something went wrong with that request. Please try again.