Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Signup button not opening modal on FF (Windows only) #20

Closed
JackLot opened this issue Jan 25, 2024 · 1 comment
Closed

[BUG] Signup button not opening modal on FF (Windows only) #20

JackLot opened this issue Jan 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JackLot
Copy link
Owner

JackLot commented Jan 25, 2024

In FireFox the signup button fails to open the payment details modal. This is because the SimpleAnalytics window.sa_event function is not loading.
@JackLot JackLot added the bug Something isn't working label Jan 25, 2024
@JackLot
Copy link
Owner Author

JackLot commented Jan 25, 2024

The fix for now was to just wrap the event function in a try/catch. Failure to send an analytics event shouldn't result in critical functionality failing.

@JackLot JackLot closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JackLot