Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CF_Trace, CF_Log, CF_Date, CF_Localiser #74

Merged
merged 20 commits into from Dec 6, 2021
Merged

Conversation

Jacob-Mango
Copy link
Collaborator

No description provided.

@Jacob-Mango Jacob-Mango mentioned this pull request Aug 16, 2021
Copy link
Owner

@Arkensor Arkensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why log levels are implemented as bitmask ... That is rather odd

Also without docs and all the other code from other branches, it is not easy to give feedback. I will only re-review after docs were added so I can understand the core additions of this.

JM/CF/Scripts/1_Core/CommunityFramework/CF_LogLevel.c Outdated Show resolved Hide resolved
Copy link
Owner

@Arkensor Arkensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CF_Date Compare needs some major attention or needs to be scrapped. If the Compare feature was not new and I just noticed in this rename, then it needs work at a later time.

CF_Trace needs better explanations so users understand when and how to use it.

Some minor naming/description suggestions.

Details in the comments.

JM/CF/Scripts/1_Core/CommunityFramework/CF_String.c Outdated Show resolved Hide resolved
JM/CF/Scripts/1_Core/CommunityFramework/CF_String.c Outdated Show resolved Hide resolved
JM/CF/Scripts/1_Core/CommunityFramework/CF_String.c Outdated Show resolved Hide resolved
JM/CF/Scripts/1_Core/CommunityFramework/CF_String.c Outdated Show resolved Hide resolved
JM/CF/Scripts/1_Core/CommunityFramework/CF_String.c Outdated Show resolved Hide resolved
docs/Logging/index.md Outdated Show resolved Hide resolved
docs/Logging/index.md Show resolved Hide resolved
docs/Logging/index.md Outdated Show resolved Hide resolved
docs/Date/index.md Show resolved Hide resolved
docs/Date/index.md Show resolved Hide resolved
This was referenced Dec 5, 2021
docs/Localiser/index.md Outdated Show resolved Hide resolved
docs/Localiser/index.md Outdated Show resolved Hide resolved
JM/CF/Scripts/1_Core/CommunityFramework/Logging/CF_Trace.c Outdated Show resolved Hide resolved
@Arkensor Arkensor merged commit 3a6690b into development Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants