optionally include active templating library #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The links are not needed on windows, they are only present to resolve casing differences on case-sensitive file systems. |
|
I know that symlinks are just for emulating a case insensitive filesystem. I mean with my comment that I personally do not develop on windows so I would not know if there is any sourcecode that uses uppercase names for atl. However it seems that atl is internally all lowercase so I think that symlinks are not required. In the meantime I have found a way to remove the atl dependency from my personal usease but the option might be nice for other people nontheless |
Jake-Shadle
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The microsoft active templating library (ATL) is used by some c++ libraries that rust crates might wish to link to (the lld linker for my usecase). This PR adds an optional flag that includes ATL with the installation.
I currently did not add any symlinks, because I am not sure if they are required (I personally do not work on windows), before merging it should be resolved whether any links are needed