Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bump up roboguice-sherlock version. Try to fix the `can't resolve startActivity()` error. #457

Merged
merged 3 commits into from

2 participants

@zhen9ao

Intellij IDEA would complain without the jar dependency.

@JakeWharton
Owner

Does mvn clean verify pass?

@zhen9ao

Yeah, it passed.

[INFO] Reactor Summary:
[INFO]
[INFO] ActionBarSherlock (Parent) ........................ SUCCESS [0.432s]
[INFO] ActionBarSherlock ................................. SUCCESS [29.533s]
[INFO] Sample (Parent) ................................... SUCCESS [0.005s]
[INFO] Sample: Demos ..................................... SUCCESS [20.754s]
[INFO] Sample: Fragments ................................. SUCCESS [18.563s]
[INFO] Sample: RoboGuice ................................. SUCCESS [18.634s]
[INFO] Sample: Styled .................................... SUCCESS [16.496s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:45.547s
[INFO] Finished at: Tue May 08 11:04:00 GMT+08:00 2012
[INFO] Final Memory: 24M/81M
[INFO] ------------------------------------------------------------------------

@JakeWharton
Owner

Use ${project.version} for the ABS depenedency.

@zhen9ao

Done

@JakeWharton JakeWharton merged commit 2e60488 into JakeWharton:dev
@zhen9ao

After changing the explicit version to ${project.version}, the IDE still complain.

I found that Intellij doesn't import the right jar dependency but rather there are two apklib dependencies of Library, one Compile the other Provided.

@zhen9ao

Roboguice-sherlock requires com.actionbarsherlock.library 4.0.2 as a provided one, do we have to change the dependency version of sample-roboguice to 4.0.2?

@JakeWharton
Owner

That's simply the version that it compiles against. Its provided scope allows us to always substitute the latest version when actually using the library.

@zhen9ao

Maybe this is a bug of Intellij, similar to this http://youtrack.jetbrains.com/issue/IDEA-81856

@JakeWharton
Owner

Yeah it's probably not an issue with the actual Maven configuration as command line building works fine. I've voted for the issue and will watch its progress. I'm also seeing the same errors appear in IntelliJ so it's not just you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 1 deletion.
  1. +8 −1 samples/roboguice/pom.xml
View
9 samples/roboguice/pom.xml
@@ -33,7 +33,14 @@
<dependency>
<groupId>com.github.rtyley</groupId>
<artifactId>roboguice-sherlock</artifactId>
- <version>1.1</version>
+ <version>1.4</version>
+ </dependency>
+ <dependency>
+ <groupId>com.actionbarsherlock</groupId>
+ <artifactId>library</artifactId>
+ <version>${project.version}</version>
+ <type>jar</type>
+ <scope>provided</scope>
</dependency>
</dependencies>
Something went wrong with that request. Please try again.