This repository has been archived by the owner. It is now read-only.

Preserve tab behavior onOrientationChange (issue #365) #549

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@yigit

yigit commented Jul 12, 2012

This commit fixes tab behavior bug onOrientationChange when Activity handles orientation changes (android:configChanges="orientation").

Probably, this is not the proper implementation because it re-creates tab layout but for our case, it solves the problem.
Tested on Android 2.3.4 and Android 4.0.4.

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jul 12, 2012

Jake Wharton » ActionBarSherlock #27 SUCCESS
This pull request looks good
(what's this?)

Jake Wharton » ActionBarSherlock #27 SUCCESS
This pull request looks good
(what's this?)

@Unlogic-dot-se

This comment has been minimized.

Show comment
Hide comment
@Unlogic-dot-se

Unlogic-dot-se Oct 16, 2012

I've tested these changes and they indeed solve the problem with tab rotation when the Activity is configured using android:configChanges="orientation|keyboardHidden" in the manifest.

I've tested these changes and they indeed solve the problem with tab rotation when the Activity is configured using android:configChanges="orientation|keyboardHidden" in the manifest.

@SimonVT

This comment has been minimized.

Show comment
Hide comment
@SimonVT

SimonVT Oct 16, 2012

Collaborator

Tabs aren't the only thing affected by runtime changes, which is why this won't be merged. That, and handling runtime changes is horrible.

Collaborator

SimonVT commented Oct 16, 2012

Tabs aren't the only thing affected by runtime changes, which is why this won't be merged. That, and handling runtime changes is horrible.

@Unlogic-dot-se

This comment has been minimized.

Show comment
Hide comment
@Unlogic-dot-se

Unlogic-dot-se Oct 16, 2012

Okay, I understand that the fix may have side effects and cannot be merged. The bug however is valid and causes tabs to become unresponsive when orientation changes on Android 2.x (haven't tested 3.x).

The native ActionBar tabs on Android 4.x handles the rotation just fine when android:configChanges="orientation|keyboardHidden" is set on the activity.

Edit: Ignore this comment, I found Jake's reply on the bug here #279

Okay, I understand that the fix may have side effects and cannot be merged. The bug however is valid and causes tabs to become unresponsive when orientation changes on Android 2.x (haven't tested 3.x).

The native ActionBar tabs on Android 4.x handles the rotation just fine when android:configChanges="orientation|keyboardHidden" is set on the activity.

Edit: Ignore this comment, I found Jake's reply on the bug here #279

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.