New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change verb from 'inject' to 'bind'. #243

Merged
merged 1 commit into from Mar 15, 2015

Conversation

2 participants
@JakeWharton
Owner

JakeWharton commented Mar 14, 2015

  • InjectView becomes FindView
  • InjectViews becomes FindViews
  • ButterKnife.inject() becomes ButterKnife.bind()
  • ButterKnife.reset() becomes ButterKnife.unbind()
  • Previously deprecated Nullable annotation is removed.
Change verb from 'inject' to 'bind'.
* InjectView becomes FindView
* InjectViews becomes FindViews
* ButterKnife.inject() becomes ButterKnife.bind()
* ButterKnife.reset() becomes ButterKnife.unbind()
* Previously deprecated Nullable annotation is removed.
@artem-zinnatullin

This comment has been minimized.

Show comment
Hide comment
@artem-zinnatullin

artem-zinnatullin Mar 15, 2015

Contributor

O_o finally 👍

grep -rl "inject" ./*"

gives this:

./README.md
./butterknife/src/main/java/butterknife/ButterKnife.java
./butterknife/src/main/java/butterknife/internal/Binding.java
./butterknife/src/main/java/butterknife/internal/ButterKnifeProcessor.java
./butterknife/src/main/java/butterknife/internal/ViewInjector.java
./butterknife/src/main/java/butterknife/Nullable.java
./butterknife/src/main/java/butterknife/package-info.java
./butterknife/src/test/java/butterknife/ButterKnifeTest.java
./butterknife/src/test/java/butterknife/internal/AllTheThingsTest.java
./butterknife/src/test/java/butterknife/internal/InjectViewsTest.java
./butterknife/src/test/java/butterknife/internal/InjectViewTest.java
./butterknife/src/test/java/butterknife/internal/OnCheckedChangedTest.java
./butterknife/src/test/java/butterknife/internal/OnClickTest.java
./butterknife/src/test/java/butterknife/internal/OnEditorActionTest.java
./butterknife/src/test/java/butterknife/internal/OnFocusChangeTest.java
./butterknife/src/test/java/butterknife/internal/OnItemClickTest.java
./butterknife/src/test/java/butterknife/internal/OnItemLongClickTest.java
./butterknife/src/test/java/butterknife/internal/OnItemSelectedTest.java
./butterknife/src/test/java/butterknife/internal/OnLongClickTest.java
./butterknife/src/test/java/butterknife/internal/OnPageChangeTest.java
./butterknife/src/test/java/butterknife/internal/OnTextChangedTest.java
./butterknife/src/test/java/butterknife/internal/OnTouchTest.java
./butterknife-sample/src/main/java/com/example/butterknife/SimpleActivity.java
./butterknife-sample/src/main/java/com/example/butterknife/SimpleAdapter.java
./pom.xml
./website/ide-eclipse.html
./website/ide-idea.html
./website/index.html

Or if this PR will be merged, I can make PR with fixes for these files

Contributor

artem-zinnatullin commented Mar 15, 2015

O_o finally 👍

grep -rl "inject" ./*"

gives this:

./README.md
./butterknife/src/main/java/butterknife/ButterKnife.java
./butterknife/src/main/java/butterknife/internal/Binding.java
./butterknife/src/main/java/butterknife/internal/ButterKnifeProcessor.java
./butterknife/src/main/java/butterknife/internal/ViewInjector.java
./butterknife/src/main/java/butterknife/Nullable.java
./butterknife/src/main/java/butterknife/package-info.java
./butterknife/src/test/java/butterknife/ButterKnifeTest.java
./butterknife/src/test/java/butterknife/internal/AllTheThingsTest.java
./butterknife/src/test/java/butterknife/internal/InjectViewsTest.java
./butterknife/src/test/java/butterknife/internal/InjectViewTest.java
./butterknife/src/test/java/butterknife/internal/OnCheckedChangedTest.java
./butterknife/src/test/java/butterknife/internal/OnClickTest.java
./butterknife/src/test/java/butterknife/internal/OnEditorActionTest.java
./butterknife/src/test/java/butterknife/internal/OnFocusChangeTest.java
./butterknife/src/test/java/butterknife/internal/OnItemClickTest.java
./butterknife/src/test/java/butterknife/internal/OnItemLongClickTest.java
./butterknife/src/test/java/butterknife/internal/OnItemSelectedTest.java
./butterknife/src/test/java/butterknife/internal/OnLongClickTest.java
./butterknife/src/test/java/butterknife/internal/OnPageChangeTest.java
./butterknife/src/test/java/butterknife/internal/OnTextChangedTest.java
./butterknife/src/test/java/butterknife/internal/OnTouchTest.java
./butterknife-sample/src/main/java/com/example/butterknife/SimpleActivity.java
./butterknife-sample/src/main/java/com/example/butterknife/SimpleAdapter.java
./pom.xml
./website/ide-eclipse.html
./website/ide-idea.html
./website/index.html

Or if this PR will be merged, I can make PR with fixes for these files

@JakeWharton

This comment has been minimized.

Show comment
Hide comment
@JakeWharton

JakeWharton Mar 15, 2015

Owner

All of the ones worth fixing are already fixed. I didn't bother with the tests.

Owner

JakeWharton commented Mar 15, 2015

All of the ones worth fixing are already fixed. I didn't bother with the tests.

JakeWharton added a commit that referenced this pull request Mar 15, 2015

Merge pull request #243 from JakeWharton/jw/bind
Change verb from 'inject' to 'bind'.

@JakeWharton JakeWharton merged commit 34d3082 into master Mar 15, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@JakeWharton JakeWharton deleted the jw/bind branch Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment