Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.lang.VerifyError while using @DebugLog anywhere in my app #9

Closed
MufriA opened this issue Dec 6, 2013 · 60 comments
Closed

java.lang.VerifyError while using @DebugLog anywhere in my app #9

MufriA opened this issue Dec 6, 2013 · 60 comments

Comments

@MufriA
Copy link

@MufriA MufriA commented Dec 6, 2013

        dalvikvm  W  VFY: invoke type does not match method type of Lcom/example/MyActivity;.someMethodToLog
                    W  VFY:  rejecting opcode 0x6f at 0x0000
                    W  VFY:  rejected Lcom/example/MyActivity;.access$1000 (Lcom/example/MyActivity;)V
                    W  Verifier rejected class Lcom/example/MyActivity;
                    W  Class init failed in newInstance call (Lcom/example/MyActivity;)
    AndroidRuntime  D  Shutting down VM
          dalvikvm  W  threadid=1: thread exiting with uncaught exception (group=0x417d3898)
    AndroidRuntime  E  FATAL EXCEPTION: main
                    E  java.lang.VerifyError: com/example/MyActivity
                    E      at java.lang.Class.newInstanceImpl(Native Method)
                    E      at java.lang.Class.newInstance(Class.java:1130)
                    E      at android.app.Instrumentation.newActivity(Instrumentation.java:1078)
                    E      at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2220)
                    E      at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2359)
                    E      at android.app.ActivityThread.access$700(ActivityThread.java:165)
                    E      at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1326)
                    E      at android.os.Handler.dispatchMessage(Handler.java:99)
                    E      at android.os.Looper.loop(Looper.java:137)
                    E      at android.app.ActivityThread.main(ActivityThread.java:5455)
                    E      at java.lang.reflect.Method.invokeNative(Native Method)
                    E      at java.lang.reflect.Method.invoke(Method.java:525)
                    E      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1187)
                    E      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
                    E      at dalvik.system.NativeStart.main(Native Method)
@JulienDev
Copy link

@JulienDev JulienDev commented Dec 7, 2013

Same here 👍

12-07 21:29:02.132  15116-15116/com.jumy.twitterclient W/dalvikvm﹕ VFY: invoke type does not match method type of Lcom/jumy/twitterclient/ui/UserFragment;.setLoadingVisibility
12-07 21:29:02.132  15116-15116/com.jumy.twitterclient W/dalvikvm﹕ VFY:  rejecting opcode 0x6f at 0x0000
12-07 21:29:02.132  15116-15116/com.jumy.twitterclient W/dalvikvm﹕ VFY:  rejected Lcom/jumy/twitterclient/ui/UserFragment;.access$600 (Lcom/jumy/twitterclient/ui/UserFragment;Z)V
12-07 21:29:02.132  15116-15116/com.jumy.twitterclient W/dalvikvm﹕ Verifier rejected class Lcom/jumy/twitterclient/ui/UserFragment;
12-07 21:29:02.132  15116-15116/com.jumy.twitterclient D/AndroidRuntime﹕ Shutting down VM
12-07 21:29:02.132  15116-15116/com.jumy.twitterclient W/dalvikvm﹕ threadid=1: thread exiting with uncaught exception (group=0x4152cba8)
12-07 21:29:02.132  15116-15116/com.jumy.twitterclient E/AndroidRuntime﹕ FATAL EXCEPTION: main
    Process: com.jumy.twitterclient, PID: 15116
    java.lang.VerifyError: com/jumy/twitterclient/ui/UserFragment
            at com.jumy.twitterclient.ui.UserActivity.showUserFragment(UserActivity.java:139)
            at com.jumy.twitterclient.ui.UserActivity.onCreate(UserActivity.java:94)
            at android.app.Activity.performCreate(Activity.java:5231)
            at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
            at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2159)
            at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2245)
            at android.app.ActivityThread.access$800(ActivityThread.java:135)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:136)
            at android.app.ActivityThread.main(ActivityThread.java:5017)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
            at dalvik.system.NativeStart.main(Native Method)

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 9, 2013

Provide more info. Method signature, android version, etc.

Loading

@MufriA
Copy link
Author

@MufriA MufriA commented Dec 10, 2013

Android ver : 4.3
Built with: Android Studio with gradle
Source compatibility : 1.7

Added debuglog in,

 @DebugLog
    private void doCheck() {

however error seems to be in importFromGoogleAuth, which doesn't have annotation

  private void importFromGoogleAuth() {

dalvikvm  W  VFY: invoke type does not match method type of Lcom/mufri/authenticatorplus/AuthenticatorActivity;.importFromGoogleAuth
                    W  VFY:  rejecting opcode 0x6f at 0x0000
                    W  VFY:  rejected Lcom/mufri/authenticatorplus/AuthenticatorActivity;.access$1000 (Lcom/mufri/authenticatorplus/AuthenticatorActivity;)V
                    W  Verifier rejected class Lcom/mufri/authenticatorplus/AuthenticatorActivity;
                    W  Class init failed in newInstance call (Lcom/mufri/authenticatorplus/AuthenticatorActivity;)
    AndroidRuntime  D  Shutting down VM
          dalvikvm  W  threadid=1: thread exiting with uncaught exception (group=0x4186d898)
    AndroidRuntime  E  FATAL EXCEPTION: main
                    E  java.lang.VerifyError: com/mufri/authenticatorplus/AuthenticatorActivity
                    E      at java.lang.Class.newInstanceImpl(Native Method)
                    E      at java.lang.Class.newInstance(Class.java:1130)
                    E      at android.app.Instrumentation.newActivity(Instrumentation.java:1078)
                    E      at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2220)
                    E      at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2359)
                    E      at android.app.ActivityThread.access$700(ActivityThread.java:165)
                    E      at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1326)
                    E      at android.os.Handler.dispatchMessage(Handler.java:99)
                    E      at android.os.Looper.loop(Looper.java:137)
                    E      at android.app.ActivityThread.main(ActivityThread.java:5455)
                    E      at java.lang.reflect.Method.invokeNative(Native Method)
                    E      at java.lang.reflect.Method.invoke(Method.java:525)
                    E      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1187)
                    E      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
                    E      at dalvik.system.NativeStart.main(Native Method)

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 10, 2013

Are you able to reproduce this in a different, simple file? Something that plays more like an example that you'd be comfortable sharing. And then can you send both the java and the compiled class file over?

It's hard to see what's really going on with the generated code unless I have a class file to inspect.

Loading

@MufriA
Copy link
Author

@MufriA MufriA commented Dec 10, 2013

I'm unable to reproduce the issue in simple classes, always reproduced in few classes, I will try to reproduce and send you the logs,

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 10, 2013

Thanks!
On Dec 10, 2013 2:33 AM, "MufriA" notifications@github.com wrote:

I'm unable to reproduce the issue in simple classes, always reproduced in
few classes, I will try to reproduce and send you the logs,


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-30214711
.

Loading

@DHuckaby
Copy link

@DHuckaby DHuckaby commented Dec 10, 2013

@JakeWharton In testing to boil down my class into an example I found I understand less and less about what is going on with this issue. I was able however to provide a simple example to reproduce it.

https://gist.github.com/DHuckaby/08258c12ab311d5374c2

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 10, 2013

We just hit an app internally that does this as well. I'll try to look
tonight.

If any eager souls out there want to give it a shot it'll start with
running "javap -cp" on the compiled code and inspecting what the re-written
bytecode looks like.


Jake Wharton
http://about.me/jakewharton

On Tue, Dec 10, 2013 at 10:16 AM, Daniel Huckaby
notifications@github.comwrote:

@JakeWharton https://github.com/JakeWharton In testing to boil down my
basic class into an example I found I understand less and less about what
is going on with this issue. I was able however able to provide a simple
example to reproduce it.

https://gist.github.com/DHuckaby/08258c12ab311d5374c2


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-30252990
.

Loading

@danielkutik
Copy link
Contributor

@danielkutik danielkutik commented Dec 11, 2013

@DHuckaby I just ran your code and couldn't find any issue:

D/Example﹕ ⇢ test()
D/Example﹕ ⇠ test [0ms]

I'm running this code on my Nexus 4 with API 19 (Android 4.4) with hugo 1.0.1.

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 11, 2013

I have a compiled version of a class file that exhibits this behavior that I need to do inspect later.

@DHuckaby Can you post the compiled class file of the example above when it fails for you?

Loading

@chrisjenx
Copy link
Contributor

@chrisjenx chrisjenx commented Dec 11, 2013

OK great we ran into this yesterday. +1

Loading

@danielkutik
Copy link
Contributor

@danielkutik danielkutik commented Dec 11, 2013

Can anybody share a bit of code that reproduces this issue?

Loading

@chrisjenx
Copy link
Contributor

@chrisjenx chrisjenx commented Dec 11, 2013

Not without giving away alot of internal code, but whats odd is its unrelated, it caused VerifyErrors on code which wasn't tagged with @DebugLog, very odd.

Loading

@danielkutik
Copy link
Contributor

@danielkutik danielkutik commented Dec 11, 2013

The class was not tagged at all? Be aware that line numbers might be incorrect.

Loading

@chrisjenx
Copy link
Contributor

@chrisjenx chrisjenx commented Dec 11, 2013

A calling parent method was, but was a method down the execution chain which threw the VerifyError. Sorry I can't be more helpful.. I'll see if I can pull out the offending code later.

Loading

@chrisjenx
Copy link
Contributor

@chrisjenx chrisjenx commented Dec 11, 2013

Oh and this might of already been established, but its is only an issue on Java7, change back to 1.6 and all is smooth sailing.

Loading

@DHuckaby
Copy link

@DHuckaby DHuckaby commented Dec 11, 2013

@danielkutik Did you compile it against java 7?

@JakeWharton What exactly do you want? The .class file?

Loading

@JulienDev
Copy link

@JulienDev JulienDev commented Dec 11, 2013

Also compiled using java 7

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 11, 2013

Yes. The class file. Preferably in the smallest possible file you can get
the error to occur in. I don't want to sift through thousands of bytecode
instructions.
On Dec 11, 2013 6:15 AM, "JulienDev" notifications@github.com wrote:

Also compiled using java 7


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-30323089
.

Loading

@DHuckaby
Copy link

@DHuckaby DHuckaby commented Dec 11, 2013

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 11, 2013

Excellent. Can you paste the verify logs that correspond to this file too?

Loading

@DHuckaby
Copy link

@DHuckaby DHuckaby commented Dec 11, 2013

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 11, 2013

@DHuckaby Are you able to get a class file that was compiled with Java 6 that does not exhibit the failure.

Loading

@DHuckaby
Copy link

@DHuckaby DHuckaby commented Dec 11, 2013

@JakeWharton Here you go, it works fine with Java 6. http://cloud.tweedleapp.com/3U122y0Z413S

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 11, 2013

My best guess thus far is the ACC_SYNTHETIC access flag is causing the runtime to blow up. Does the Java 7-compiled version fail on Android 4.4?

Loading

@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 11, 2013

Actually ACC_SYNTHETIC is in the Java 6 version but not Java 7. Ugh. Question about 4.4 still stands, though.

Loading

@DHuckaby
Copy link

@DHuckaby DHuckaby commented Dec 11, 2013

@JakeWharton It crashes on 4.4 also, tested on a stock Moto X.

Loading

@chrisjenx
Copy link
Contributor

@chrisjenx chrisjenx commented Dec 11, 2013

@JakeWharton same, HTC One GE 4.4.1 Java7 VerifyError.

On 11 December 2013 17:57, Daniel Huckaby notifications@github.com wrote:

@JakeWharton https://github.com/JakeWharton It crashes on 4.4 also,
tested on a stock Moto X.


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-30344241
.

Loading

@danielkutik
Copy link
Contributor

@danielkutik danielkutik commented Dec 12, 2013

I so far have never experienced this issue... I compiled https://gist.github.com/DHuckaby/08258c12ab311d5374c2 with java7 and android sdk 19 running it on my nexus 4 (4.4) (not 4.4.1!?).
You guys are running Dalvik I guess.. ever cared to try ART? Just to narrow it down. We still don't know where the issue is:

  • Hugo
  • Android SDK (please try other versions?)
  • AspectJ
  • Java
  • Android/Dalvik?

I don't want to blame it simply on other projects :) but let's find a reproducible issue (environment + sourcecode)...

Please try to run the failing apk also on emulated environments (same OS version as well as different ones)

Loading

@DHuckaby
Copy link

@DHuckaby DHuckaby commented Dec 12, 2013

@danielkutik From your comment it doesn't sound like you tested it using Dalvik. ART is an experimental runtime, I wouldn't use it for debugging anything at this point if it bombs out on the default runtime.

Here is a full example project importing the very simple example, and it still crashes:
https://github.com/DHuckaby/HugoCrashExample

Loading

@vinc3m1
Copy link

@vinc3m1 vinc3m1 commented Mar 11, 2014

Actually, now that I'm trying to reproduce it with hugo-example, the only way to get a crash is to use include a synchronized block. Simply adding:

synchronized (Boolean.TRUE) {}

causes it to crash.

Then of course, if you make all your methods non-private after that, it will run fine....

Loading

@loeschg
Copy link

@loeschg loeschg commented Mar 28, 2014

I'm getting this same issue. Haven't seen it work yet. Seems to blow up when I instantiate a fragment in a private internal class (internal FragmentStatePagerAdapter). I'm also using

compileOptions {
    sourceCompatibility JavaVersion.VERSION_1_7
    targetCompatibility JavaVersion.VERSION_1_7
}

Loading

@jonasfa
Copy link

@jonasfa jonasfa commented Jun 19, 2014

#9 (comment) and #9 (comment) describe exactly how I get this error: Java 7 + private method accessed from a inner class

Loading

@burgalon
Copy link

@burgalon burgalon commented Jul 21, 2014

In a weird way, this has happened to me several times and seemed to be related to ternary expressions

Loading

@williamwebb
Copy link

@williamwebb williamwebb commented Jul 23, 2014

Just to add, i also experienced this bug when using JavaVersion.VERSION_1_7, switching to 1.6 does not cause the bug.

Loading

@AndrewReitz
Copy link

@AndrewReitz AndrewReitz commented Sep 25, 2014

I'm seeing the same thing as vinc3m1, I have a method that when marked private it causes this issue. Change it to package protected, no problem. Any suggestions on where I can look to help figure out what is causing this?

Loading

@thevoiceless
Copy link

@thevoiceless thevoiceless commented Oct 17, 2014

Same issue here after setting source and target compatibility to 1.7; The behavior I'm seeing (VerifyError when accessing private methods from inner classes) and the workaround (making everything either public or protected) match up with what @vinc3m1 found

Loading

@yogurtearl
Copy link

@yogurtearl yogurtearl commented Oct 24, 2014

In my case:

This gives a VerifyError:

        final int value = 5 + (flag ? 4 : 7);

Switching to this works just fine ( no other changes ):

        final int value = (flag ? 4 : 7) + 5;

Putting that code in a minimal class for SSCCE didn't trigger the error. :(
It only triggers VerifyError as part of my larger class.

The code above is NOT in a @debuglog method.

The VerifyError points to another method in the same class ( also not a @debuglog method ).

But if I remove all @debuglog from that particular class, everything works fine...

( Using JDK 7 javac )
( fails on ART/Lollipop as well )

Loading

@fschoellhammer
Copy link

@fschoellhammer fschoellhammer commented Nov 14, 2014

I am not sure if this is related, I am using AspectJ in a different project, and I noticed if I use sdk buildtools 19 (19.1.0), then I get VerifyError when running advised code. If I e.g. switch to 21 (21.1.1) then it works.

Loading

yhartanto pushed a commit to yhartanto/hugo that referenced this issue Dec 8, 2014
The issue seems to have been resolved by upgrading to the latest build tools.
yhartanto pushed a commit to yhartanto/hugo that referenced this issue Dec 9, 2014
The issue seems to have been resolved by upgrading to the latest build tools.
@yhartanto
Copy link
Contributor

@yhartanto yhartanto commented Dec 9, 2014

I was able to reproduce this issue by adding the empty synchronized (Boolean.True) {} in the example code. I am sure the issue is not caused by hugo but it seems to be related to how the code generated in dex does not comply with Dalvik VM verification.

When I upgraded to the latest set of build tools, the issue goes away.

Loading

yhartanto pushed a commit to yhartanto/hugo that referenced this issue Dec 9, 2014
The issue seems to have been resolved by upgrading to the latest build tools.
yhartanto pushed a commit to yhartanto/hugo that referenced this issue Dec 9, 2014
The issue seems to have been resolved by upgrading to the latest build tools.
yhartanto pushed a commit to yhartanto/hugo that referenced this issue Dec 9, 2014
The issue seems to have been resolved by upgrading to the latest build tools.
yhartanto pushed a commit to yhartanto/hugo that referenced this issue Dec 9, 2014
The issue seems to have been resolved by upgrading to the latest build tools.
yhartanto pushed a commit to yhartanto/hugo that referenced this issue Dec 9, 2014
The issue seems to have been resolved by upgrading to the latest build tools.
@JakeWharton
Copy link
Owner

@JakeWharton JakeWharton commented Dec 17, 2014

Fixed by #62.

Loading

@msdx
Copy link

@msdx msdx commented May 3, 2016

java.lang.VerifyError while using @DebugLog anywhere and instant run in my app.
hugo:1.1.0
com.android.tools.build:gradle:2.1.0

Loading

@reisub
Copy link

@reisub reisub commented May 3, 2016

@msdx The latest Hugo version is 1.2.1, you should try with that one first as it should contain a fix for this issue.

Loading

@msdx
Copy link

@msdx msdx commented May 3, 2016

@reisub The new version 1.2.1 has the same result.

java.lang.VerifyError: com/parkingwang/app/WangApplication$AjcClosure1
    at com.parkingwang.app.WangApplication.onCreate(WangApplication.java:92)
    at com.android.tools.fd.runtime.BootstrapApplication.onCreate(BootstrapApplication.java:326)
    at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1007)
    at android.app.ActivityThread.handleBindApplication(ActivityThread.java:4570)
    at android.app.ActivityThread.access$1300(ActivityThread.java:147)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1332)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:137)
    at android.app.ActivityThread.main(ActivityThread.java:5265)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:525)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:760)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:576)
    at dalvik.system.NativeStart.main(Native Method)

Loading

@tentypwtk
Copy link

@tentypwtk tentypwtk commented May 6, 2016

+1. latest hugo, gradle tools 2.0.0. Interestingly it only happens on older android I use for testing. No problems on 5.1, but old 4.1.2 phone crashes on any method annotated with @debuglog.

Loading

@vboesch
Copy link

@vboesch vboesch commented May 9, 2016

+1 same problem as tentypwtk, crash with device 4.4, but not newer android os version

Loading

2 similar comments
@lovexiaov
Copy link

@lovexiaov lovexiaov commented Jun 8, 2016

+1 same problem as tentypwtk, crash with device 4.4, but not newer android os version

Loading

@msdx
Copy link

@msdx msdx commented Jun 8, 2016

+1 same problem as tentypwtk, crash with device 4.4, but not newer android os version

Loading

@epetrenko
Copy link

@epetrenko epetrenko commented Jun 21, 2016

+1. I can confirm the appearance of this issue. Tested on Nexus 7 (2012 edition) with Android 4.2. Hugo version is the latest. Gradle version is 2.1.2. On newer android versions all is working just fine.

Loading

@asclines
Copy link

@asclines asclines commented Jul 7, 2016

+1 Using Hugo version 1.2.1 and Gradle version 2.1.0

Works when minsdk = 20 but not when minsdk = 19

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet