New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem writing lyrics in id3v2 caused by Grammar error 'unsychronised_lyric' #136

Closed
KeitelDOG opened this Issue Dec 6, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@KeitelDOG

KeitelDOG commented Dec 6, 2017

$ID3v2ShortFrameNameLookup[2]['unsychronised_lyric'] = 'ULT';

$ID3v2ShortFrameNameLookup[3]['unsychronised_lyric'] = 'USLT';

Many people will have difficulties following the demo because when we put the key 'unsynchronised_lyrics', or 'unsynchronised_lyric' in $dataTags, it won't work.

Because the line 1982 and 2057 have misspelled the word unsynchronised with unsychronised.

I had headache since the day before yesterday, when I finally go hacking the codes I found them.

JamesHeinrich added a commit that referenced this issue Dec 6, 2017

@JamesHeinrich

This comment has been minimized.

Owner

JamesHeinrich commented Dec 6, 2017

Thanks. Fixed in 1767b53

The typo got in there because that's the way it was (and still is) written in the ID3v2 v2.3 specifications document.

@KeitelDOG

This comment has been minimized.

KeitelDOG commented Dec 6, 2017

Oh great. Sorry for this, Thanks

@JamesHeinrich

This comment has been minimized.

Owner

JamesHeinrich commented Dec 6, 2017

Nothing to be sorry about, thanks for catching the typo. It certainly makes more sense to spell it right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment