From 0769273cc26fea2ee91b43a7f5110823f52df2c4 Mon Sep 17 00:00:00 2001 From: James Ives Date: Fri, 15 Sep 2023 21:57:46 -0400 Subject: [PATCH] fix: remove base.Dockerfile as it's not needed --- .devcontainer/base.Dockerfile | 7 ------- .devcontainer/devcontainer.json | 13 ++++++++++--- 2 files changed, 10 insertions(+), 10 deletions(-) delete mode 100644 .devcontainer/base.Dockerfile diff --git a/.devcontainer/base.Dockerfile b/.devcontainer/base.Dockerfile deleted file mode 100644 index de5299b45..000000000 --- a/.devcontainer/base.Dockerfile +++ /dev/null @@ -1,7 +0,0 @@ -ARG VARIANT=18 -FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:dev-${VARIANT} - -# Install tslint, typescript. eslint is installed by javascript image -ARG NODE_MODULES="tslint-to-eslint-config typescript" -RUN su node -c "umask 0002 && npm install -g ${NODE_MODULES}" \ - && npm cache clean --force > /dev/null 2>&1 \ No newline at end of file diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 5d246391c..3ad063332 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -7,9 +7,16 @@ "VARIANT": "18" } }, - "settings": { - "terminal.integrated.shell.linux": "/bin/bash" + "customizations": { + "env": { + "PATH": "/usr/local/share/.config/yarn/global/node_modules/.bin:$PATH" + }, + "vscode": { + "settings": { + "terminal.integrated.shell.linux": "/bin/bash" + }, + "extensions": ["dbaeumer.vscode-eslint"] + } }, - "extensions": ["dbaeumer.vscode-eslint"], "remoteUser": "node" }