Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fixes an issue where informational messages are throwing errors #1168

merged 1 commit into from Jul 20, 2022


Copy link


Reported here #1167

Testing Instructions

You can point your workflow to JamesIves/github-pages-deploy-action@releases/v4-st to test this.

Additional Notes

If the error starts with fatal: and it's not rejected, we throw, otherwise the message is allowed to go through.

@JamesIves JamesIves linked an issue Jul 17, 2022 that may be closed by this pull request
Copy link

Codecov Report

Merging #1168 (d210695) into dev (e8f5095) will decrease coverage by 0.35%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev    #1168      +/-   ##
- Coverage   98.20%   97.85%   -0.36%     
  Files           7        7              
  Lines         279      280       +1     
  Branches       76       76              
  Hits          274      274              
- Misses          5        6       +1     
Impacted Files Coverage Δ
src/git.ts 95.61% <50.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f5095...d210695. Read the comment docs.

@JamesIves JamesIves merged commit 331dd26 into dev Jul 20, 2022
8 of 10 checks passed
@JamesIves JamesIves deleted the fix-non-fatal-commits branch July 20, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Regular git warning causes build failure
2 participants