Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all adapters are unregistered correctly #17

Closed
JamesLMilner opened this issue Jan 8, 2023 · 1 comment
Closed

Ensure all adapters are unregistered correctly #17

JamesLMilner opened this issue Jan 8, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JamesLMilner
Copy link
Owner

I haven't fully checked, but my gut instinct is that the unregister methods for the adapters maybe be out of date/sync with the register methods. We should ensure these are updated to reflect the state of the register methods.

Essentially we need to:

  1. Go through each adapter
  2. Look at the registered events
  3. Ensure there is an equivalent unregister event in the unregister method
@JamesLMilner JamesLMilner added bug Something isn't working good first issue Good for newcomers labels Jan 8, 2023
@JamesLMilner
Copy link
Owner Author

JamesLMilner commented Feb 5, 2023

The AdapterListener pattern should have helped with this as now you are forced to call unregister on each listener (i.e. it must be defined). This was introduced in 0.0.15-alpha

Following up on #18 should help make sure this is all handled correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant