James Newton-King
JamesNK

Jul 25, 2016
JamesNK commented on pull request erichexter/Should#11
@JamesNK

They're for backwards compatibility.

Jul 25, 2016
JamesNK commented on pull request JamesNK/Newtonsoft.Json#969
@JamesNK

Added a couple more tests to my branch 4f86f6b

Jul 25, 2016
@JamesNK
Jul 24, 2016
JamesNK commented on pull request JamesNK/Newtonsoft.Json#969
@JamesNK

I've fixed the build error.

Jul 24, 2016
@JamesNK
Jul 24, 2016
@JamesNK
Jul 24, 2016
JamesNK commented on pull request JamesNK/Newtonsoft.Json#969
@JamesNK

I've made a couple of changes to make it closer to the behavior of double.TryParse and add some more tests. Main issue at the moment is the inconsi…

Jul 24, 2016
Jul 23, 2016
JamesNK commented on pull request JamesNK/Newtonsoft.Json#969
@JamesNK

I've been adding some more tests and I found at least one case where the result isn't consistent: Assert.AreEqual(1E-23, Convert.ToDouble("1E-23")…

Jul 22, 2016
JamesNK commented on pull request JamesNK/Newtonsoft.Json#969
@JamesNK

Oh, interesting! I've always wanted to do this but floating point math isn't my forte. Thanks. I'll look at this later tonight. Key thing will be t…

Jul 22, 2016
@JamesNK

Json.NET already supports switching between methods of doing reflection. The simplest solution would be a flag somewhere on the .NET Core runtime t…

Jul 21, 2016
@JamesNK

Hi I'm not sure whether ids and references are case sensitive or not. I'll have to look into that. The rules around resolving references aren't ver…

Jul 21, 2016
JamesNK closed pull request JamesNK/Newtonsoft.Json#846
@JamesNK
JsonTextReader supports parsing large numeric value by using custom handler
Jul 21, 2016
JamesNK commented on pull request JamesNK/Newtonsoft.Json#846
@JamesNK

I don't want to add work arounds for older versions of .NET. If someone is using .NET 3.5 and they have very large numbers then they have the optio…

Jul 21, 2016
JamesNK closed pull request JamesNK/Newtonsoft.Json#420
@JamesNK
Deserializing anonymous json into ordinary dictionaries and arrays using a converter
Jul 21, 2016
JamesNK commented on pull request JamesNK/Newtonsoft.Json#420
@JamesNK

I think this would be a good option for a converter in a separate NuGet package. I'm trying hard to keep the size of the core Json.NET library small.

Jul 21, 2016
JamesNK closed pull request JamesNK/Newtonsoft.Json#295
@JamesNK
Add ability to grab delimiters and whitespace during parsing and make it...
Jul 21, 2016
JamesNK commented on pull request JamesNK/Newtonsoft.Json#295
@JamesNK

Hi I've thought about this and I don't want to add this complexity to JsonTextReader, which very few people will use. It is possible for those peop…

Jul 20, 2016
@JamesNK

// --> This should really be Assert.True No it shouldn't. Once again, you're using GetHashCode. They're different references, Equals returns fals…

Jul 20, 2016
@JamesNK
NullValueHandling.Ignore not working as expected with ExpandoObject
Jul 20, 2016
@JamesNK

It's by design. NullValueHandling is only for properties on classes. An ExpandoObject is like a dictionary.

Jul 20, 2016
@JamesNK
ommit zero values on convert
Jul 20, 2016
@JamesNK

Hi. You should ask questions like this on StackOverflow

Jul 20, 2016
@JamesNK

Thanks, fixed 6d7ac14

Jul 20, 2016
@JamesNK
Class DynamicReflectionDelegateFactory,method CreateDefaultConstructor has a bug
Jul 20, 2016
@JamesNK
  • @JamesNK 6d7ac14
    -Fixed DynamicReflectionDelegateFactory creating typed value type con…
Jul 20, 2016
@JamesNK
Add Converter for converting integer types to JSON string and back
Jul 20, 2016
@JamesNK

Someone can make it and put it on NuGet but I don't want it part of the core library to keep it small.

Jul 20, 2016
@JamesNK
Exception when building for windows store WUA