Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add details to 'Essential patterns' section #4

Open
hanleybrand opened this Issue Mar 14, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@hanleybrand
Copy link

hanleybrand commented Mar 14, 2019

I found your guide (I'm just getting started with my first mod), and it seems to have some great advice, so thanks for taking the time to share it.

It would be more useful if you added a bit more detail for clarity for less experienced mod developers. I'm assuming that at some point that I would instinctively know (or be able to guess) what class or interface should implement the withBlock method, and what class implements the registry method (or least guess how you implemented it)

registry.registerAll(
    withName(new Block(Material.GRASS), "example_block"),
// ...
);

It's occurred to me that this might be pseudocode or a method that's disappeared from mcp (I'm using stable_39 currently), but even so it would be helpful if you gave a brief concrete example of a BaseClass that would typify the "BaseClass trap" you describe (for example, would this class BlockIdfk from Voidaic-Arcania be a good example?), followed up with with an example alternate class or whatever it is you're describing.

Again, I'd like to thank you for what you've shared - I'm only offering a suggestion that I think would widen the value of your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.