From 1cb754babb9de357d7ca476b0e323b049fd01b3c Mon Sep 17 00:00:00 2001 From: Jan De Dobbeleer Date: Thu, 20 Jun 2024 12:13:07 +0200 Subject: [PATCH] fix(upgrade): disable upgrade feedback when notice is disabled resolves #5124 --- src/cli/upgrade.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/cli/upgrade.go b/src/cli/upgrade.go index b4820653462b..8ca0fbe1133b 100644 --- a/src/cli/upgrade.go +++ b/src/cli/upgrade.go @@ -4,6 +4,7 @@ import ( "fmt" "runtime" + "github.com/jandedobbeleer/oh-my-posh/src/engine" "github.com/jandedobbeleer/oh-my-posh/src/platform" "github.com/jandedobbeleer/oh-my-posh/src/upgrade" "github.com/spf13/cobra" @@ -34,8 +35,12 @@ var upgradeCmd = &cobra.Command{ return } + cfg := engine.LoadConfig(env) + if _, hasNotice := upgrade.Notice(env, true); !hasNotice { - fmt.Print("\n✅ no new version available\n\n") + if !cfg.DisableNotice { + fmt.Print("\n✅ no new version available\n\n") + } return }