From ae10564f2bf8c02d5ee3c637f41f02383bcb6abd Mon Sep 17 00:00:00 2001 From: Jan De Dobbeleer Date: Sat, 6 Feb 2021 18:13:20 +0100 Subject: [PATCH] refactor: remove MissingCommandText --- src/segment_language.go | 8 +++----- src/segment_language_test.go | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/segment_language.go b/src/segment_language.go index 1a661f4c6df0..43ffda102944 100644 --- a/src/segment_language.go +++ b/src/segment_language.go @@ -81,10 +81,8 @@ const ( DisplayModeEnvironment string = "environment" // DisplayModeContext displays the segment when the environment or files is active DisplayModeContext string = "context" - // MissingCommandTextProperty sets the text to display when the command is not present in the system - MissingCommandTextProperty Property = "missing_command_text" - // MissingCommandText displays empty string by default - MissingCommandText string = "" + // MissingCommandText sets the text to display when the command is not present in the system + MissingCommandText Property = "missing_command_text" ) func (l *language) string() string { @@ -152,7 +150,7 @@ func (l *language) setVersion() error { l.activeCommand = command return nil } - return errors.New(l.props.getString(MissingCommandTextProperty, MissingCommandText)) + return errors.New(l.props.getString(MissingCommandText, "")) } func (l *language) loadLanguageContext() { diff --git a/src/segment_language_test.go b/src/segment_language_test.go index 48982069b6d9..b2c7ffb2a1e2 100644 --- a/src/segment_language_test.go +++ b/src/segment_language_test.go @@ -52,7 +52,7 @@ func bootStrapLanguageTest(args *languageArgs) *language { }, } if args.missingCommandText != "" { - props.values[MissingCommandTextProperty] = args.missingCommandText + props.values[MissingCommandText] = args.missingCommandText } l := &language{ props: props, @@ -78,7 +78,7 @@ func TestLanguageFilesFoundButNoCommandAndVersionAndDisplayVersion(t *testing.T) } lang := bootStrapLanguageTest(args) assert.True(t, lang.enabled()) - assert.Equal(t, MissingCommandText, lang.string(), "unicorn is not available") + assert.Equal(t, "", lang.string(), "unicorn is not available") } func TestLanguageFilesFoundButNoCommandAndVersionAndDontDisplayVersion(t *testing.T) {